fix: Normalize URL for Nexus3 deployer #1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
aalmiray
requested changes
Aug 18, 2025
| @@ -20,6 +20,7 @@ | |||
| import com.fasterxml.jackson.annotation.JsonIgnore; | |||
| import org.jreleaser.model.Active; | |||
| import org.jreleaser.model.Http; | |||
| import org.jreleaser.model.internal.validation.deploy.maven.MavenDeployersValidator; | |||
There was a problem hiding this comment.
Looks like this import was added because of the javadoc comment. Could it be removed and use the FQN classname in the comment?
There was a problem hiding this comment.
Yes, I can change that
Add normalization for the Nexus3 URL to ensure the repository trailing slash is included when performing the deploy operation. Fixes jreleasergh-1967 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
aalmiray
approved these changes
Aug 18, 2025
|
Thank you 😄 |
ThomasVitale
added a commit
to ThomasVitale/jreleaser
that referenced
this pull request
Aug 19, 2025
This reverts the change done in jreleaser#1968, which was not correct for Nexus3.
ThomasVitale
added a commit
to ThomasVitale/jreleaser
that referenced
this pull request
Aug 19, 2025
This reverts the change done in jreleaser#1968, which was not correct for Nexus3. Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
3 tasks
aalmiray
pushed a commit
that referenced
this pull request
Aug 19, 2025
This reverts the change done in #1968, which was not correct for Nexus3. Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1967
Context
Add normalization for the Nexus3 URL to ensure the repository trailing slash is included when performing the deploy operation.
Checklist
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.