Skip to content

Conversation

SaltwaterC
Copy link
Contributor

This PR adds what it says on the tin to make fpm compatible with recent Debian and derivatives which implement zstd compression for their packages.

Fixes #2007.

@jordansissel
Copy link
Owner

This was kinda funny for me to test since it fails on macOS and I forgot I was testing on this OS at the time ;) I dug a little into this, because I'd like it to work on macOS and Linux.

macOS defaults to bsdtar and -I is a synonym for -T flag which means something different than GNU tar's -I flag. Both appear to support --zstd flags, though. It's possible --zstd will fail on older tar versions.

I do see that both bsdtar (on macOS) and GNU tar seem to agree on --use-compress-program but they both disagree on what this actually means. GNU tar assumes the program will be invoked with -d and bsdtar does not do this.

Both work with --use-compress-program 'zstd -d'

I'll create a new branch using your changes and the above additions :)

@jordansissel
Copy link
Owner

Thanks for improving fpm :)

jordansissel added a commit that referenced this pull request Dec 9, 2024
When using zstd, use tar flags that are compatible with both gnu tar and bsdtar (#2009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to repackage deb packages using zstd compression
2 participants