Add sound feature #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadircancetin
approved these changes
Feb 15, 2020
|
Hello @KaratasFurkan, following up on your mail I lately saw: I think the best to test out your feature is via an integration test For instance something like Scenario: Turn on the fire make it noisy then not
When I call "fireplace"
And I switch to buffer "*fireplace*"
And I call "fireplace-toggle-sound"
And I wait for 1 second
And I call "fireplace-toggle-sound"in the file https://github.com/johanvts/emacs-fireplace/blob/master/features/emacs-fireplace.feature I can try to do it directly if you allow me to push on your branch |
|
Hello @AdrieanKhisbe, thanks for help. I send you an invitation. |
|
@KaratasFurkan received :), let see how 0dfb22a goes |
seyyidibrahimgulec
approved these changes
Mar 29, 2020
AdrieanKhisbe
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
If you want @johanvts, I can have it merge, bump the version and add a tag for melpa.
|
Nice work, go ahead @AdrieanKhisbe |
AdrieanKhisbe
added a commit
that referenced
this pull request
Apr 2, 2020
with 'Add sound feature' #31 included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.