0.5.X method cache bugfix #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And I think it makes the code clearer.
… database before failing
Memory.clear used to try and delete the whole cache directory, which caused an error since the database file has to stay open. The fix is to remove all subdirectories of the cache directory, leaving the database file intact.
original exception class
|
You had done the pull request to the master, instead of to branch 0.5.X. That's OK, I shouldn't have a master branch with unresolved features. I merged you pull request with a few minor changes. |
Merged
fcharras
pushed a commit
to fcharras/joblib
that referenced
this pull request
Apr 29, 2018
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 29, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
May 6, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
May 12, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Oct 24, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Oct 24, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Oct 24, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Nov 16, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Nov 22, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 6, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 16, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 18, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 11, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 14, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 14, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 14, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gael,
I've added a test to expose the method cache bug (see http://bit.ly/g4WBMJ) and used the pickling protocol to fix it.
Let me know what you think.
Cheers,
Nicolas Pinto