Py3K compatibility. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of fixes that 2to3 could not handle:
* in joblib.my_exceptions: exception module has been removed
somewhere between 3.1 and 3.2, so I just parse the builtins.
* in joblib.numpy_pickle : Unpickler object has no attribute
dispatch, so I use the private class _Unpickler. I ignore if it
could be implemented using any of the Unpickler methods [0].
[0] http://docs.python.org/release/3.1.3/library/pickle.html#pickle.Unpickler
|
The second fix doesn't seem to be good since I get errors in test_numpy_persistence |
fcharras
pushed a commit
to fcharras/joblib
that referenced
this pull request
Apr 29, 2018
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 29, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
May 6, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
May 12, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Oct 24, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Oct 24, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Nov 16, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Nov 21, 2022
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 6, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 15, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 15, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 16, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Feb 18, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 11, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 14, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 14, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 14, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
fcharras
added a commit
to fcharras/joblib
that referenced
this pull request
Apr 17, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes that 2to3 could not handle. These deal with some of the
most obscure parts of joblib, hopefully you'll find a more elegant solution.
somewhere between 3.1 and 3.2, so I just parse the builtins.
dispatch, so I use the private class _Unpickler. I ignore if it
could be implemented using any of the Unpickler methods [0].
[0] http://docs.python.org/release/3.1.3/library/pickle.html#pickle.Unpickler