FIX make sure pre_dispatch cannot do arbitrary code execution #1321
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
+ Coverage 93.90% 93.92% +0.01%
==========================================
Files 50 50
Lines 7270 7270
==========================================
+ Hits 6827 6828 +1
+ Misses 443 442 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for the fix! I assume that this is enough but alternatively we could try to use the Let's wait for the CI to complete before merging. |
|
I'm not sure if it's worth having this feature if we're going to parse it and add that complexity to the code 😅 |
|
The CI was green, merged. |
|
Cool! |
gma
added a commit
to gma/ngram-builder
that referenced
this pull request
Sep 30, 2022
See joblib/joblib#1321 for details.
jeremiedbb
pushed a commit
to jeremiedbb/joblib
that referenced
this pull request
Oct 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128
Make sure nothing's available to
evalforpre_dispatch.cc @ogrisel