Adapt DockerServerCredentialsTest for 2.413+ credentials page #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins 2.412 and earlier use a text area for the client key. Jenkins 2.413 and newer use an input field for the client key. Jenkins 2.413 looks much nicer with a button that is consistent with the other buttons used in the Jenkins pages. jenkinsci/jenkins#8179 is the Jenkins core pull request that implemented the change in Jenkins 2.413. Other plugins that use HTMLUnit to enter a value for the secret text may need a similar change.
This was referenced Jul 8, 2023
|
@jglick this is the fix for the test failure detected in: |
mawinter69
suggested changes
Jul 8, 2023
src/test/java/org/jenkinsci/plugins/docker/commons/credentials/DockerServerCredentialsTest.java
Outdated
Show resolved
Hide resolved
jenkinsci#140 (comment) notes that the same change was used in core so that the HTMLUnit code does not care about the type of the element being clicked.
mawinter69
approved these changes
Jul 8, 2023
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jul 9, 2023
jenkinsci/docker-commons-plugin#140 adapts the docker-commons test to the UI improvement in Jenkins 2.413 and makes it more resilient in case there are future changes in that area.
|
jenkinsci/bom#2220 shows passing tests. Once this is merged and released, the BOM pull request can be updated to include docker-commons in the plugin bill of materials |
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jul 10, 2023
The release does not include the test fix that is proposed in jenkinsci/docker-commons-plugin#140 This reverts commit 077a294.
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jul 10, 2023
jenkinsci/docker-commons-plugin#140 fixes the test issue on Jenkins 2.413 and later.
jglick
pushed a commit
to jenkinsci/bom
that referenced
this pull request
Jul 10, 2023
* Add authentication-tokens plugin to managed set Pin version 1.4 for 2.375.x * Add docker-commons to managed set * Test sample plugin with docker-commons * Test with incremental 431.vef5777319e6b_ * Use docker commons 434.v3dc53576ec32 Thanks @jglick! * Test docker-commons incremetal with test fix jenkinsci/docker-commons-plugin#140 adapts the docker-commons test to the UI improvement in Jenkins 2.413 and makes it more resilient in case there are future changes in that area. * Use docker commons 434.v3dc53576ec32 release * Revert "Use docker commons 434.v3dc53576ec32 release" The release does not include the test fix that is proposed in jenkinsci/docker-commons-plugin#140 This reverts commit 077a294. * Use docker-commons 439.va_3cb_0a_6a_fb_29 jenkinsci/docker-commons-plugin#140 fixes the test issue on Jenkins 2.413 and later. --------- Co-authored-by: Basil Crow <me@basilcrow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt DockerServerCredentialsTest for 2.413 UI improvement
Jenkins 2.412 and earlier use a text area for the client key data entry on the credentials page.
Jenkins 2.413 and newer use an input field for the client key data entry on the credentials page.
Jenkins 2.413 looks much nicer with a button that is consistent with the other buttons used in the Jenkins pages.
jenkinsci/jenkins#8179 is the Jenkins core pull request that implemented the change in Jenkins 2.413. Other plugins that use HTMLUnit to enter a value for the secret text may need a similar change. Special thanks to @mawinter69 for implementing that improvement in Jenkins 2.413.
Testing done
Compared the HTML pages generated by 2.412 and 2.413 and confirmed that 2.412 uses a textarea and 2.413 uses an input field. The 2.413 layout looks much nicer.
Automated test passes on both Jenkins 2.412 and 2.413 with this change.