Skip to content

Add docker-commons to the managed set #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 10, 2023
Merged

Add docker-commons to the managed set #2220

merged 13 commits into from
Jul 10, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jun 27, 2023 •
edited
Loading

Add docker-commons to managed set

  • Add docker-commons to managed set

Fixes #2096

Testing done

Rely on full-test

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite added developer Pull requests that merits a release for plugin developers full-test Test all LTS lines in this PR and do not halt upon first error. labels Jun 27, 2023
@MarkEWaite MarkEWaite changed the title Add docker-commons to managed set Add docker-commons plugin to managed set Jun 27, 2023
This was referenced Jun 27, 2023
Merged
Merged
@MarkEWaite MarkEWaite changed the title Add docker-commons plugin to managed set Add docker-commons to the managed set Jun 28, 2023
@MarkEWaite MarkEWaite added enhancement New feature or request and removed developer Pull requests that merits a release for plugin developers labels Jun 28, 2023
@MarkEWaite
Copy link
Contributor Author

Tests in the docker-commons plugin need to be adapted to the plugin BOM test environment. They assume access to the docker socket and I don't think that we want to require that in the plugin BOM test environment. Will need changes to the tests in the docker-commons plugin to adapt to the plugin BOM test environment.

@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Jul 8, 2023 •
edited
Loading

Proposed the test change that should allow the test to run in the plugin BOM.

@MarkEWaite
Copy link
Contributor Author

The release of docker-commons 434.xxx resolves the test failures I'd seen earlier. Unfortunately, Jenkins 2.413 shows a test failure on DockerServerCredentialsTest.configRoundTripUpdateCertificates that does not happen with Jenkins 2.412 and earlier. I'll do some further investigation to understand the change between Jenkins 2.412 and 2.413. Since we're about to choose an LTS baseline, this is a very good time to detect that type of change.

@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Jul 8, 2023 •
edited
Loading

I've submitted a docker-commons pull request to adapt the test for Jenkins 2.413 and newer. The pull request is

I've also asked a question in the Jenkins core pull request that made the change, just in case I've not understood something important. The core pull request is.

@MarkEWaite MarkEWaite mentioned this pull request Jul 8, 2023
Merged
MarkEWaite added 4 commits July 9, 2023 05:25
@MarkEWaite
Test docker-commons incremetal with test fix
ac26d34 
jenkinsci/docker-commons-plugin#140 adapts the
docker-commons test to the UI improvement in Jenkins 2.413 and makes
it more resilient in case there are future changes in that area.
@MarkEWaite
Use docker commons 434.v3dc53576ec32 release
077a294
@MarkEWaite
Revert "Use docker commons 434.v3dc53576ec32 release"
79a88d1 
The release does not include the test fix that is proposed in
jenkinsci/docker-commons-plugin#140

This reverts commit 077a294.
@MarkEWaite
Use docker-commons 439.va_3cb_0a_6a_fb_29
f58a0d4 
jenkinsci/docker-commons-plugin#140 fixes the
test issue on Jenkins 2.413 and later.
@MarkEWaite MarkEWaite marked this pull request as ready for review July 10, 2023 20:29
@MarkEWaite MarkEWaite requested a review from a team as a code owner July 10, 2023 20:29
@jglick jglick enabled auto-merge (squash) July 10, 2023 20:34
@MarkEWaite MarkEWaite linked an issue Jul 10, 2023 that may be closed by this pull request
Add Docker Commons to the managed set #2096
Closed
@jglick jglick merged commit 07c8a9a into jenkinsci:master Jul 10, 2023
@MarkEWaite MarkEWaite deleted the add-docker-commons branch July 26, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Docker Commons to the managed set
3 participants
@MarkEWaite @jglick @basil