Skip to content

Update dependency org.jenkins-ci.main:jenkins-war to v2.523 #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

Update dependency org.jenkins-ci.main:jenkins-war to v2.523 #5519

merged 1 commit into from
Aug 14, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 12, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
org.jenkins-ci.main:jenkins-war 2.522 -> 2.523 age confidence

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file weekly-test labels Aug 12, 2025
@renovate renovate bot requested a review from a team as a code owner August 12, 2025 18:11
@renovate renovate bot enabled auto-merge (squash) August 12, 2025 18:11
@MarkEWaite
Copy link
Contributor

It appears that one of the changes in Jenkins 2.523 has caused 2 tests in the extensible-choice-parameter-plugin to fail. I can confirm the failures from inside the extensible-choice-parameter-plugin repository with the command:

mvn clean -Djenkins.version=2.523 -Dtest=SystemGroovyChoiceListProviderJenkinsTest verify

I can confirm that the test passes with the command:

mvn clean -Djenkins.version=2.522 -Dtest=SystemGroovyChoiceListProviderJenkinsTest verify

@krisstern since you are BOM release lead this week, are you able to bisect the change in Jenkins core or would you prefer that we look for someone else that can identify the issue and either propose a change to the SystemGroovyChoiceListProviderJenkinsTest or to Jenkins core?

@basil
Copy link
Member

basil commented Aug 13, 2025

I haven't done a proper bisect, but a quick glance at the exception

org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: Scripts not permitted to use method jenkins.model.FullyNamed getFullName

makes me suspect jenkinsci/jenkins#10827

@krisstern
Copy link
Member

Hi @MarkEWaite apologies for the delayed response, but if someone else could look into this while I shadow along that would be great

@alecharp
Copy link
Member

I'm running a bisect to see where the problem is coming from.

@krisstern
Copy link
Member

Thanks @alecharp! Appreciate it

@alecharp
Copy link
Member

Because ExampleStepTest.smokes is failing (TestTimeOut), I don't get a definitive answer from bisecting.

@alecharp
Copy link
Member

I don't know how I can trust the new run of bisect but it points to jenkinsci/jenkins@211bdd1

@MarkEWaite
Copy link
Contributor

I've confirmed that it is jenkinsci/jenkins#10827 . I confirmed that I can duplicate the test failures with the commands:

cd ~/hub/core/jenkins && git checkout master && git pull
mvn -DskipTests install
cd ~/hub/plugins/extensible-choice-parameter-plugin
mvn -Djenkins.version=2.524-SNAPSHOT -Dtest=SystemGroovyChoiceListProviderJenkinsTest#test*Variable* test

I've confirmed that I can resolve the test failures with the commands:

cd ~/hub/core/jenkins && git pull && git checkout -b my-revert master && git revert --no-edit 0673bc698e
mvn -DskipTests install
cd ~/hub/plugins/extensible-choice-parameter-plugin
mvn -Djenkins.version=2.524-SNAPSHOT -Dtest=SystemGroovyChoiceListProviderJenkinsTest#test*Variable* test

MarkEWaite added a commit to MarkEWaite/extensible-choice-parameter-plugin that referenced this pull request Aug 13, 2025
@MarkEWaite
Adapt tests to jenkins.model.FullyNamed interface in 2.523
1a3197d 
Fix two tests that are blocking the Jenkins plugin BOM upgrade from
Jenkins 2.522 to 2.523.  Blocked pull request is:

* jenkinsci/bom#5519

New interface was added in Jenkins core pull request:

* jenkinsci/jenkins#10827

Add a script approval for jenkins.model.FullyNamed.getFullName() since the
tests already have a script approval for hudson.model.Item.getFullName().
Keeps the tests consistent and allows the tests to pass with both older
and newer Jenkins versions.

Testing done:

Confirmed that tests pass with Jenkins 2.523 and with default Jenkins version.
@MarkEWaite MarkEWaite mentioned this pull request Aug 13, 2025
Merged
6 tasks
@MarkEWaite
Copy link
Contributor

Updated tests for the plugin are included in the pull request:

@timja
Copy link
Member

timja commented Aug 14, 2025

Blueocean test is flakey, raised #5527 for investigation

@renovate renovate bot force-pushed the renovate/org.jenkins-ci.main-jenkins-war-2.x branch from 1ed800d to c469e09 Compare August 14, 2025 14:48
@renovate renovate bot merged commit 1a010d0 into master Aug 14, 2025
288 of 289 checks passed
@renovate renovate bot deleted the renovate/org.jenkins-ci.main-jenkins-war-2.x branch August 14, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file weekly-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarkEWaite @basil @krisstern @alecharp @timja