[JENKINS-43353] Option to disable concurrent builds by aborting previous ones #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2021
…r every build to finish
https://github.com/jenkinsci/jenkins/blob/794770f7b27b323a42c07ae03d2cb64a0acb5a8d/core/src/main/java/hudson/model/Run.java#L352 sounds incorrect for `WorkflowRun`, which can survive restart. https://github.com/jenkinsci/jenkins/blob/794770f7b27b323a42c07ae03d2cb64a0acb5a8d/core/src/main/java/hudson/model/Run.java#L910-L913 looks like it could break lazy-loading in some cases. Anyway for purposes of this feature we really only care about the previous build: there should not be _intermediate_ completed builds once this mode takes effect.
basil
reviewed
Jul 1, 2021
...va/org/jenkinsci/plugins/workflow/job/properties/DisableConcurrentBuildsJobPropertyTest.java
Outdated
Show resolved
Hide resolved
basil
approved these changes
Jul 1, 2021
Closed
6 tasks
timja
approved these changes
Oct 12, 2021
jtnord
approved these changes
Oct 12, 2021
Vlatombe
approved these changes
Oct 12, 2021
car-roll
approved these changes
Oct 12, 2021
This was referenced Oct 12, 2021
Merged
6 tasks
|
@cathychan & @jtnord point out that when introducing this option for the first time, say to replace the |
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jun 28, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jun 28, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jun 28, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jun 28, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jun 28, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jul 5, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jul 13, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-mobile
that referenced
this pull request
Jul 13, 2022
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-43353, more straightforward and efficient than using the previous hack
Can be configured via GUI (for standalone Pipelines) or as code