Swiftfin - Help Wanted! #1503
Replies: 10 comments 33 replies
-
|
This is wonderful! Thank you! One thing I'd like to add is that people with technical writing/project management skills can help lay out projects in an easy to track manner. Currently, without lists like this it's hard to know what needs finished or what features are entirely missing. If someone has experience in this area and can help bridge the gap between the greater Jellyfin project and Swiftfin, that would be awesome! |
Beta Was this translation helpful? Give feedback.
-
|
Absolutely! It's on my list to try and get organized and figure out project boards, and all of that. Eventually, my goal would be have this discussion just link to whatever I can get set up. That being said, there's a certain amount of cleanup that comes first. So, tagging issues, removing duplicates, figuring out priorities, etc.. For now, I went back to the old, trusty discussion since we've been getting feedback that people were looking to help out and I wanted to make sure we weren't leaving anybody out to dry waiting for us to build a project board haha |
Beta Was this translation helpful? Give feedback.
-
|
Just as a quick update, I'm currently working on this. I recently did something similar at my day job so I am gonna be a bit slow getting this together. Just a tad burnt out on project boards right now haha |
Beta Was this translation helpful? Give feedback.
-
|
On Media Downloads:
I mentioned this in the PR but it would be quite helpful to have this shifted to a Swiftfin-managed feature branch so that contributors don't need to coordinate PRs into each-others forks since we aren't around all of the time or consistently... that PR hasn't seen any movement for quite some time. I'd be happy to run cherry-picks to ensure proper attribution (I think that will work) if this is something agreed upon. OR What are thoughts on a lightweight bespoke feature flagging system to allow for partial work to be committed to the main branch without exposing to end-users? Or heck we can wrap some of the work in |
Beta Was this translation helpful? Give feedback.
-
|
Making a specific branch for this makes sense to me. Primarily, I don't want to rug pull #1065 or undermine what they've done so far. Right now, until #1203 is done, downloads are harder to work on. Just since, you can build the downloading and the views but playback would have to be postponed until the offline player is complete. That being said, if that is something you wanna tackle, I'd be happy to grease the wheels and make sure everything is set up for success! Let me get back to you on a best route for this! |
Beta Was this translation helpful? Give feedback.
-
|
I started working on
I am not a developer, so I am not sure if I did right. Here is what I did:
was that the correct way of doing this? |
Beta Was this translation helpful? Give feedback.
-
|
There are two parts so it might make sense to go section by section. You are spot on for the localization change. So the goal is to only update the item on the right: The item on the left like Once you have the strings done, if you do a build we have a script that does a duplicate check and alphabetizes if anything changed. Let me know if you need any guidance on building! Part 2 is doing a control+F and seeing if the label is used in a That being said, if you want to open what you've done so far as a draft PR I can help out with that part! |
Beta Was this translation helpful? Give feedback.
-
|
For part 1: I did exactly how you described. For example I changed: to I build the App followed the contribution guidelines and had no problem. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
So that example is a variable returning a string as a result of switching on the enum value, those are localizable, yes! However, if it's an enum definition, then no it cannot be localized as the Edit: yes the commit to your fork looks correct 🙂 thank you! |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the feedback :) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for looking at this! I threw together a quick python script to find "Strings" and output them to a CSV file. This is far from perfect since this is going to pick up a lot of The script is very simple but you're welcome to use that as well if this is helpful: Script |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the script, it certainly helps in finding some obscure text that would be difficult to track down just by looking through the app |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
I'll take this if you've not started back up on it |
Beta Was this translation helpful? Give feedback.
-
|
I have not! What I have on the linked branch is up to date with as far as I've gotten. You're totally welcome to scrap what I have. Part of where I stopped is I realized it would probably be best for the SDK to have a I think it's just 3 places we need to check:
Where I ended on that linked branch I only have ServerCheck. Let me know if you have questions or anything I help link you towards! I really appreciate you picking this up! |
Beta Was this translation helpful? Give feedback.
-
|
For issues, this one would attach to #1091 since this should close that out. That was originally for 10.9 but we skipped and went straight to 10.10. PR for the SDK change: jellyfin/jellyfin-sdk-swift#45 |
Beta Was this translation helpful? Give feedback.
-
|
Hi @samglt apologies for the shakeup. I ended up knocking this out here: #1574. We were starting to get our first post-10.10 issues so I wanted to make sure I got something ready ASAP. Apologies for the change up! |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
I am a software developer & heavy swiftin user and would be more than happy to contribute. However, I have no dev experience in the apple ecosystem & do not have any MacOS machines. Is it possible for me to help without spending money on a new machine or vm? edit: to be clear, I wish to help with the tvOS app. |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately, without a macOS machine, I'm not sure of any official way to test. I've seen folks be able to do it in VS code, but I think emulating is out of the question. You could push the code to from your device to your physical Apple TV for testing, but unfortunately, I'm not sure how you would do that without Xcode. For Swiftfin, we're pretty integrated with Apple and their development environment. I don't think it's impossible to contribute without macOS, but I think it would require a lot of work arounds that I'm not aware of. |
Beta Was this translation helpful? Give feedback.
-
|
I might be mistaken but i think mixed libraries is on dead row server side? this is a comment from a dev
|
Beta Was this translation helpful? Give feedback.
-
|
Yes and no: (well, yes and mostly yes) From a personal standpoint, I've never really understood mixed libraries. It's also a library type we actually have NO documentation for, so creating a dummy library for testing is difficult. But, it is still a feature in Jellyfin and, until it's been removed, should be eligible for Swiftfin IMO. It's primarily made this list because it's a frequently requested feature. |
Beta Was this translation helpful? Give feedback.
-
|
I guess it would be help-full if the devs just came straight out and said it would be removed at date x instead of vague remarks |
Beta Was this translation helpful? Give feedback.
-
|
There has been no official decision. At this point there is no consensus on the future of mixed libraries. The meta discussion should be the place any future communication happens on that front. |
Beta Was this translation helpful? Give feedback.
-
good to know. Thanks |
Beta Was this translation helpful? Give feedback.
-
|
Are there any UI elements other than #1152 that could use marquee text? The text in that issue now wraps instead of extending off screen, and I wonder if that's generally a better solution than having a moving marquee. Looking around I don't think any text in Swiftfin needs to be both line limited and to show the full text at the same time. |
Beta Was this translation helpful? Give feedback.
-
|
I forgot about tvOS, I see how it's appropriate in that more vertically constrained environment. I modified my library and getting that focus behavior on tvOS was straightforward. The demo below was a drop-in replacement for Text(), with only a frame(maxWidth) added to get the text to truncate when not animated. tvmarquee.mov |
Beta Was this translation helpful? Give feedback.
-
|
That looks solid! We might want some additional |
Beta Was this translation helpful? Give feedback.
-
|
@samglt Marquee looks great! I was playing around with this today for the Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-20.at.15.29.38.mp4Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-20.at.15.30.19.mp4iOS Code//
// Swiftfin is subject to the terms of the Mozilla Public
// License, v2.0. If a copy of the MPL was not distributed with this
// file, you can obtain one at https://mozilla.org/MPL/2.0/.
//
// Copyright (c) 2025 Jellyfin & Jellyfin Contributors
//
import Defaults
import JellyfinAPI
import Logging
import SwiftUI
extension ItemView {
struct PlayButton: View {
@Default(.accentColor)
private var accentColor
@Router
private var router
@ObservedObject
var viewModel: ItemViewModel
private let logger = Logger.swiftfin()
// MARK: - ddd
private var isEnabled: Bool {
viewModel.selectedMediaSource != nil
}
// MARK: - Title
private var title: String {
/// Use the Media Source name if there is more than one Media Source
if let sourceLabel = viewModel.selectedMediaSource?.displayTitle,
viewModel.item.mediaSources?.count ?? 0 > 1
{
return sourceLabel
/// Use the Season/Episode label for the Series ItemView
} else if let seriesViewModel = viewModel as? SeriesItemViewModel,
let seasonEpisodeLabel = seriesViewModel.playButtonItem?.seasonEpisodeLabel
{
return seasonEpisodeLabel
/// Use a Play/Resume label for single Media Source items that are not Series
} else if let playButtonLabel = viewModel.playButtonItem?.playButtonLabel {
return playButtonLabel
/// Fallback to a generic `Play` label
} else {
return L10n.play
}
}
// MARK: - Body
var body: some View {
Button {
play()
} label: {
ZStack {
Rectangle()
.foregroundStyle(isEnabled ? accentColor : Color.secondarySystemFill)
.cornerRadius(10)
HStack {
Image(systemName: "play.fill")
.font(.system(size: 20))
Marquee(title, delay: 3)
.font(.callout)
.fontWeight(.semibold)
}
.foregroundStyle(isEnabled ? accentColor.overlayColor : Color(UIColor.secondaryLabel))
.padding(.horizontal, 10)
}
}
.contextMenu {
if viewModel.playButtonItem?.userData?.playbackPositionTicks != 0 {
Button(L10n.playFromBeginning, systemImage: "gobackward") {
play(fromBeginning: true)
}
}
}
.disabled(!isEnabled)
}
// MARK: - Play Content
private func play(fromBeginning: Bool = false) {
guard var playButtonItem = viewModel.playButtonItem,
let selectedMediaSource = viewModel.selectedMediaSource
else {
logger.error("Play selected with no item or media source")
return
}
if fromBeginning {
playButtonItem.userData?.playbackPositionTicks = 0
}
router.route(
to: .videoPlayer(
manager: OnlineVideoPlayerManager(
item: playButtonItem,
mediaSource: selectedMediaSource
)
)
)
}
}
}Simulator.Screen.Recording.-.Apple.TV.4K.3rd.generation.-.2025-07-20.at.15.25.04.mp4tvOS Code//
// Swiftfin is subject to the terms of the Mozilla Public
// License, v2.0. If a copy of the MPL was not distributed with this
// file, you can obtain one at https://mozilla.org/MPL/2.0/.
//
// Copyright (c) 2025 Jellyfin & Jellyfin Contributors
//
import JellyfinAPI
import Logging
import SwiftUI
extension ItemView {
struct PlayButton: View {
@Router
private var router
@ObservedObject
var viewModel: ItemViewModel
@FocusState
private var isFocused: Bool
private let logger = Logger.swiftfin()
// MARK: - Media Sources
private var mediaSources: [MediaSourceInfo] {
viewModel.playButtonItem?.mediaSources ?? []
}
// MARK: - Multiple Media Sources
private var multipleVersions: Bool {
mediaSources.count > 1
}
// MARK: - Validation
private var isEnabled: Bool {
viewModel.selectedMediaSource != nil
}
// MARK: - Title
private var title: String {
/// Use the Media Source name if there is more than one Media Source
if let sourceLabel = viewModel.selectedMediaSource?.displayTitle,
viewModel.item.mediaSources?.count ?? 0 > 1
{
return sourceLabel
/// Use the Season/Episode label for the Series ItemView
} else if let seriesViewModel = viewModel as? SeriesItemViewModel,
let seasonEpisodeLabel = seriesViewModel.playButtonItem?.seasonEpisodeLabel
{
return seasonEpisodeLabel
/// Use a Play/Resume label for single Media Source items that are not Series
} else if let playButtonLabel = viewModel.playButtonItem?.playButtonLabel {
return playButtonLabel
/// Fallback to a generic `Play` label
} else {
return L10n.play
}
}
// MARK: - Body
var body: some View {
HStack(spacing: 20) {
playButton
if multipleVersions {
VersionMenu(viewModel: viewModel, mediaSources: mediaSources)
.frame(width: 100, height: 100)
}
}
}
// MARK: - Play Button
private var playButton: some View {
Button {
play()
} label: {
HStack(spacing: 15) {
Image(systemName: "play.fill")
.font(.title3)
.padding(.trailing, 10)
Marquee(title, animateWhenFocused: true)
.fontWeight(.semibold)
}
.foregroundStyle(isEnabled ? .black : Color(UIColor.secondaryLabel))
.padding(20)
.frame(width: multipleVersions ? 320 : 440, height: 100, alignment: .center)
.background {
if isFocused {
isEnabled ? Color.white : Color.secondarySystemFill
} else {
Color.white
.opacity(0.5)
}
}
.cornerRadius(10)
}
.buttonStyle(.card)
.contextMenu {
if viewModel.playButtonItem?.userData?.playbackPositionTicks != 0 {
Button(L10n.playFromBeginning, systemImage: "gobackward") {
play(fromBeginning: true)
}
}
}
.disabled(!isEnabled)
.focused($isFocused)
}
// MARK: - Play Content
private func play(fromBeginning: Bool = false) {
guard var playButtonItem = viewModel.playButtonItem,
let selectedMediaSource = viewModel.selectedMediaSource
else {
logger.error("Play selected with no item or media source")
return
}
if fromBeginning {
playButtonItem.userData?.playbackPositionTicks = 0
}
router.route(
to: .videoPlayer(
manager: OnlineVideoPlayerManager(
item: playButtonItem,
mediaSource: selectedMediaSource
)
)
)
}
}
} |
Beta Was this translation helpful? Give feedback.
-
|
For ease of testing, I've just been changing: from:
to:
since I don't personally have multiple versions. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! I'll tweak those and put up a PR to complete this |
Beta Was this translation helpful? Give feedback.
-
|
If anyone is interested in working on "📐 Remove Usages of the Now-Deprecated In this PR, I remove |
Beta Was this translation helpful? Give feedback.
-
|
I've made a PR for CinematicScrollView (#1646) and I'll take a look at the other item views next: CompactLogoScrollView and CompactPortraitScrollView |
Beta Was this translation helpful? Give feedback.
-
Thank you for starting on that! Just as a heads up, it might be wise to take your time. Just so LePips can get his feedback in and any revisions. That way, if there's anything major he would prefer us use instead, we don't have to rework too much. That all being said, I think what you have in this first one looks great! Thank you for your help in this! |
Beta Was this translation helpful? Give feedback.
-
|
Yeah I'll keep it at one PR for now. I noticed while doing my PR that GeometryReader can initially have zero height and/or width before it settles, so if we size images with that proxy size, it will initially request max res images before it requests an appropriately sized one. I stuck an if check to deal with that, but I don't know if we want to do that for every single dynamically sized image. Another thing I noticed is that the ImageViews don't seem to respond to the imagesource changing in maxheight/width, which could be a problem on iPadOS since images can change in size significantly between device orientations. |
Beta Was this translation helpful? Give feedback.
-
That's a good note. Especially looking at iPad variable sizing or things like Split Screen. I think once we get some clarity from LePips this should be good to proceed but this is definitely a good example of what they can shine some light on. |
Beta Was this translation helpful? Give feedback.
-
|
Looks like we were on the right track! I think this is good to resume. Apologies for the stop and go, I just wanted to be sure I wasn't leading you astray. I'd say full steam ahead! Thank you again for your help with this!! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
🚀 Help Wanted!
Join the Swiftfin Community of Contributers
Are you interested in contributing to Swiftfin? This guide outlines various ways you can help improve the application, regardless of your development experience.
💫 Why Contribute to Swiftfin?
Swiftfin belongs to all of us! As an open-source project, it thrives on community contributions. Every bug fix, translation, and feature you add makes the experience better for thousands of Jellyfin users across Apple devices. Whether you're a seasoned Swift developer or just getting started, your unique perspective can help us build something amazing together!
🤔 How Can I Help?
Below are some of the outstanding opportunities that you could help with to make Swiftfin better. While this list isn't comprehensive, it does contain some of the biggest pain-points that the core Swiftfin team haven't had the opportunity to address yet.
Some of these are ongoing efforts that continuously improve Swiftfin's quality and user experience. Others are one-off projects that will help take Swiftfin to the next level by adding important functionality or fixing persistent issues. As new items arise, we will keep this list updated to ensure there's a centralized place for contributors to get started.
🌟 Evergreen Opportunities
These are ongoing ways to contribute that are always valuable and help maintain Swiftfin's quality. We're constantly looking for community members to help with these essential tasks:
🐛 Helping Troubleshoot / Recreate Issues
Contributing to issue resolution is one of the most valuable ways to help. This involves:
🧪 Testing and Reporting Issues with TestFlight
Quality assurance is crucial for a stable app:
🔍 Assistance with Finding Duplicate Issues
Help us maintain an organized issue tracker by:
🌐 Translation Assistance
Help make Swiftfin accessible to users worldwide:
📚 Documentation
Good documentation enhances user experience significantly:
📋 Documentation Maintenance
Helping maintain our existing resources:
🌱 For New Developers
These tasks are perfect starting points if you're new to Swift development or the Swiftfin codebase:
🪵 Logger Cleanup
Help us update old versions of our logger with the new version:
LoggerService🧵 String Case Standardization
This project involves improving UI text consistency:
localizedCapitalized()function to ensure view titles are capitalized appropriately⚙️ Settings Organization
Improve the user experience in the settings area:
🔄 Intermediate Skill Levels
Ready for more substantial contributions? These tasks require a bit more experience:
📐 Remove Usages of the Now-Deprecated
UIDevice.mainHelp modernize Swiftfin’s layout system by removing outdated uses of
UIDevice.main.boundsand similar sizing logic.UIDevice.main.bounds,UIScreen.main.bounds, orUIScreen.main.scalewith SwiftUI-native alternativesGeometryReader,trackingSize, or other environment-aware sizing where appropriateUIDevice.mainis usedItemView.iPadOSCinematicScrollView🔒 HTTP to HTTPS Security Warning
Improve HTTPS detection by implementing proper protocol validation:
🔢 Enhanced Sort Options
Expand sorting capabilities for better content organization:
PagingLIbraryView🚀 Advanced Projects
For experienced developers looking for challenging tasks:
📱 PosterButton Context Menus
Add context menu functionality to poster buttons:
🔑 tvOS Logout on Background
Currently, there is an option on tvOS to log the user out on background idle for a set duration. This should mirror iOS. This functionality is not working as expected on tvOS while functional on iOS. This is NOT related to #776. The goal of this would be to determine what is not triggering as expected (timer, logout, etc.) and ensure that iOS and tvOS both have functional logout on background for X:
🧙♂️ Other Projects
For experienced Swift and SwiftUI developers:
🧩 Miscellaneous Items
📼 MPV / Alternative Player
Assist us in building a wrapper around MPV and packaging it for SwiftUI:
📥 Media Downloads
This multi-faceted feature requires coordinated development:
🔀 Mixed Library Support
Enable libraries containing multiple content types:
🚀 Getting Started
The Jellyfin team appreciates all contributions, from documentation improvements to complex feature implementations. Your help makes this Swiftfin better for everyone!
Questions, comments, or concerns? Think I missed something? Please feel free to reach out in the discussion below and I can assist you there!
Beta Was this translation helpful? Give feedback.
All reactions