Skip to content

feat(badge): show & hide badge based on v-model value #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2022
Merged

feat(badge): show & hide badge based on v-model value #51

merged 6 commits into from
Nov 3, 2022

Conversation

brojor
Copy link
Contributor

@brojor brojor commented Oct 23, 2022

Based on issue #8 I add the option to hide/show based on v-model

@netlify
Copy link

netlify bot commented Oct 23, 2022 •
edited
Loading

✅ Deploy Preview for anu-vue ready!

Name Link
🔨 Latest commit 7cc78ac
🔍 Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/636328196b812c000893d9b5
😎 Deploy Preview https://deploy-preview-51--anu-vue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jd-solanki
Copy link
Owner

Hi @brojor

Thanks so much for your continuous contribution. I really appreciate it 🙏🏻

Everything is fine. I just want to know, have you enabled eslint in the project?

In packages/documentation/docs/demos/badge/DemoBadgeVModel.vue there's an indentation issue:
image

Sorry, I wasn't able to review it earlier because I was busy with office work and other stuff.

Thanks for your patience 😇

@jd-solanki jd-solanki changed the title feat(badge): Allow showing & hiding based on v-model feat(badge): show & hide badge based on v-model value Nov 3, 2022
@jd-solanki jd-solanki merged commit feba268 into jd-solanki:main Nov 3, 2022
@brojor
Copy link
Contributor Author

brojor commented Nov 4, 2022

@jd-solanki I have eslint on and it should lint on save. However, somehow it stopped working. I need to fix this, or run linter from the command line before commit.

@jd-solanki
Copy link
Owner

No worries. We have to add some more rules for eslint. e.g. max attrs per line to better view the git diff.

ATM I explored how to add them for TSX file, eslint-plugin-vue was doing this for Vue SFC.

jd-solanki added a commit to brojor/anu that referenced this pull request Nov 27, 2022
@brojor @jd-solanki
feat(badge): show & hide badge based on v-model value (jd-solanki#51)
bfdab2f 
Co-authored-by: JD Solanki <jdsolanki0001@gmail.com>
Co-authored-by: JD Solanki <47495003+jd-solanki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brojor @jd-solanki