-
Notifications
You must be signed in to change notification settings - Fork 60
Add Jakarta Validation 3.1 XSDs #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @starksm64, I'm pinging you to get this one on your radar 😃. |
I agree the older versions should retain their original naming. I'm guessing this just got caught up in the renaming process. |
hey @mswatosh 👋🏻 😃 thanks for taking a look.
I can update this patch to revert the names in the "older" XSDs. As for the missing bits for the final release of Hibernate Validator... we also have this one on the list: (Since there is no final version of the EL reference impl and Hibernate Validator having a dependency on it ... ) |
…ions of the spec this partially reverts the changes applied in 8990acd since the spec name remains the same for versions < 3.1
5bf5a3d
to
9465795
Compare
@mswatosh @starksm64 let me know if there's anything else needed for this PR. Thanks! |
The Jakarta Validation API jar for 3.0.x also does not contain the xsd files in it. Even with this PR, the jar will not be updated to include the xsd files without some additional work to change building of the jar to include the xsd files is my understanding. So what is the need for the xsd files in the 3.1 API jar if they weren't needed in previous versions of the Validation API jar? |
* Add Jakarta Validation 3.1 XSDs * Keep the original Jakarta Bean Validation name for the previous revisions of the spec this partially reverts the changes applied in 8990acd since the spec name remains the same for versions < 3.1 Co-authored-by: Marko Bekhta <marko-bekhta@users.noreply.github.com>
Hello, |
Hey @jafarre-bi please see this issue: #262 the version is currently fixed in the published XSDs :
(with this pr: jakartaee/jakarta.ee#2181) The XSDs currently bundled in As for the Hiberante Validator in particular, it should work fine with both 3.1 and 3.0 (or even 2.0 for that matter) as it bundles the XSDs on its own. |
fixes #217
While creating this patch, I noticed that the other XSDs for previous versions are using the new
Jakarta Validation
spec name. Shouldn't the name for the older version remain the same as it was when the corresponding spec was published?