Skip to content

Conversation

marko-bekhta
Copy link
Contributor

fixes #217

While creating this patch, I noticed that the other XSDs for previous versions are using the new Jakarta Validation spec name. Shouldn't the name for the older version remain the same as it was when the corresponding spec was published?

@marko-bekhta
Copy link
Contributor Author

Hey @starksm64, I'm pinging you to get this one on your radar 😃.
Once this gets merged, we'd need a 3.1.1 release. (Note that the patch targets the 3.1 branch, so we'd need to apply it to the main as well after this)

@mswatosh
Copy link
Member

I agree the older versions should retain their original naming. I'm guessing this just got caught up in the renaming process.
@starksm64 It looks like this is the only change pending for a 3.1.1 release, and I'm assuming this is a blocker for the Hibernate Validator 9.0 release?

@marko-bekhta
Copy link
Contributor Author

hey @mswatosh 👋🏻 😃 thanks for taking a look.

I agree the older versions should retain their original naming. I'm guessing this just got caught up in the renaming process.

I can update this patch to revert the names in the "older" XSDs.

As for the missing bits for the final release of Hibernate Validator... we also have this one on the list:

(Since there is no final version of the EL reference impl and Hibernate Validator having a dependency on it ... )

…ions of the spec

this partially reverts the changes applied in 8990acd since the spec name remains the same for versions < 3.1
@marko-bekhta
Copy link
Contributor Author

@mswatosh @starksm64 let me know if there's anything else needed for this PR. Thanks!

@jhanders34
Copy link
Member

jhanders34 commented Dec 17, 2024

The Jakarta Validation API jar for 3.0.x also does not contain the xsd files in it. Even with this PR, the jar will not be updated to include the xsd files without some additional work to change building of the jar to include the xsd files is my understanding. So what is the need for the xsd files in the 3.1 API jar if they weren't needed in previous versions of the Validation API jar?

@starksm64 starksm64 self-assigned this Jan 22, 2025
@starksm64 starksm64 merged commit 1b6f29f into jakartaee:3.1 Jan 23, 2025
1 check passed
starksm64 added a commit that referenced this pull request Feb 1, 2025
* Add Jakarta Validation 3.1 XSDs

* Keep the original Jakarta Bean Validation name for the previous revisions of the spec

this partially reverts the changes applied in 8990acd since the spec name remains the same for versions < 3.1

Co-authored-by: Marko Bekhta <marko-bekhta@users.noreply.github.com>
@jafarre-bi
Copy link

Hello,
I found the incorrect fixed value for the version, and I ended up here trying to determine if it was a known issue.
I saw that it's already fixed in the main branch, so I'll just wait for a new release. It's also correct in hibernate-validator 9.0.1-final.
However, I also noticed that the specification itself uses version 3.0 of the schema, which otherwise remains unchanged in version 3.1.
My question is: should I be using version 3.1 or stay with version 3.0, as specified? Will hibernate-validator work the same if I use one version or the other?
Thank you!

@marko-bekhta
Copy link
Contributor Author

Hey @jafarre-bi

please see this issue: #262

the version is currently fixed in the published XSDs :

(with this pr: jakartaee/jakarta.ee#2181)

The XSDs currently bundled in jakarta.validation-api 3.1.1 have 3.0 which is incorrect 😕.

As for the Hiberante Validator in particular, it should work fine with both 3.1 and 3.0 (or even 2.0 for that matter) as it bundles the XSDs on its own.
My suggestion would be - if you are on Hibernate Validator 9.0 and Jakarta Validation 3.1, then use the 3.1 in our XML files, if you are on Hibernate Validator 8.0 (and hence Jakarta Validation 3.0) use 3.0 in the XMLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants