Skip to content

Reuse v8 index templates for Elasticsearch v9 #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Reuse v8 index templates for Elasticsearch v9 #7320

merged 1 commit into from
Jul 16, 2025

Conversation

shuraih775
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Modified mapping logic to treat Elasticsearch v9 the same as v8 for template selection.
  • This avoids the need for a separate v9 template file and prevents runtime errors due to missing mappings.

How was this change tested?

  • Verified by running jaeger-query and jaeger-collector using Elasticsearch v9 as the storage backend.
  • Confirmed that the services start successfully and ingest/query traces without template-related errors.

Checklist

@shuraih775
Add support for Elasticsearch v9 index template creation by reusing v…
6424e8a 
…8 mapping template

Signed-off-by: Mohammed Shuraih <shuraih15@gmail.com>
@shuraih775 shuraih775 requested a review from a team as a code owner July 16, 2025 17:23
@shuraih775 shuraih775 requested a review from pavolloffay July 16, 2025 17:23
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (d321ea3) to head (6424e8a).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7320      +/-   ##
==========================================
+ Coverage   96.14%   96.28%   +0.13%     
==========================================
  Files         374      377       +3     
  Lines       22693    22900     +207     
==========================================
+ Hits        21818    22049     +231     
+ Misses        659      643      -16     
+ Partials      216      208       -8
Flag Coverage Δ
badger_v1 9.17% <0.00%> (+0.14%) ⬆️
badger_v2 1.75% <0.00%> (-0.04%) ⬇️
cassandra-4.x-v1-manual 11.91% <0.00%> (-0.03%) ⬇️
cassandra-4.x-v2-auto 1.74% <0.00%> (-0.04%) ⬇️
cassandra-4.x-v2-manual 1.74% <0.00%> (-0.04%) ⬇️
cassandra-5.x-v1-manual 11.91% <0.00%> (-0.03%) ⬇️
cassandra-5.x-v2-auto 1.74% <0.00%> (-0.04%) ⬇️
cassandra-5.x-v2-manual 1.74% <0.00%> (-0.04%) ⬇️
elasticsearch-6.x-v1 16.77% <100.00%> (+0.08%) ⬆️
elasticsearch-7.x-v1 16.82% <100.00%> (+0.08%) ⬆️
elasticsearch-8.x-v1 16.98% <100.00%> (+0.08%) ⬆️
elasticsearch-8.x-v2 1.75% <0.00%> (-0.13%) ⬇️
grpc_v1 10.42% <0.00%> (-0.02%) ⬇️
grpc_v2 1.75% <0.00%> (-0.04%) ⬇️
kafka-3.x-v1 9.33% <0.00%> (-0.02%) ⬇️
kafka-3.x-v2 1.75% <0.00%> (-0.04%) ⬇️
memory_v2 1.75% <0.00%> (-0.04%) ⬇️
opensearch-1.x-v1 16.86% <100.00%> (+0.08%) ⬆️
opensearch-2.x-v1 16.86% <100.00%> (+0.08%) ⬆️
opensearch-2.x-v2 1.75% <0.00%> (-0.04%) ⬇️
query 1.75% <0.00%> (-0.04%) ⬇️
tailsampling-processor 0.48% <0.00%> (-0.01%) ⬇️
unittests 95.20% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Jul 16, 2025
@yurishkuro yurishkuro enabled auto-merge July 16, 2025 17:57
@yurishkuro yurishkuro added this pull request to the merge queue Jul 16, 2025
@yurishkuro yurishkuro changed the title Add support for Elasticsearch v9 index template creation by reusing v8 template Reuse v8 index templates for Elasticsearch v9 Jul 16, 2025
Merged via the queue into jaegertracing:main with commit 9050880 Jul 16, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:exprimental Change to an experimental part of the code storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuraih775 @yurishkuro