Skip to content

[es/v2] Add metrics decorator for trace reader #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 13, 2025
Merged

[es/v2] Add metrics decorator for trace reader #7201

merged 8 commits into from
Jun 13, 2025

Conversation

Manik2708
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Implement metrics decorator for tracestore reader

How was this change tested?

  • Unit Tests

Checklist

Manik2708 added 3 commits May 25, 2025 01:20
@Manik2708
[v2] Implement factory for memory backend
5c2e77b 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708
[v2] Implement metrics store for tracestore
ac7b9b2 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708
Revert "[v2] Implement factory for memory backend"
49065fa 
This reverts commit 5c2e77b.

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708 Manik2708 requested a review from a team as a code owner June 4, 2025 05:34
@Manik2708 Manik2708 requested a review from jkowall June 4, 2025 05:34
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (5957be0) to head (38177c8).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7201      +/-   ##
==========================================
- Coverage   96.19%   96.16%   -0.03%     
==========================================
  Files         368      369       +1     
  Lines       22009    22088      +79     
==========================================
+ Hits        21171    21242      +71     
- Misses        626      632       +6     
- Partials      212      214       +2
Flag Coverage Δ
badger_v1 9.85% <ø> (ø)
badger_v2 1.89% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v1-manual 14.81% <ø> (ø)
cassandra-4.x-v2-auto 1.88% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2-manual 1.88% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v1-manual 14.81% <ø> (ø)
cassandra-5.x-v2-auto 1.88% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2-manual 1.88% <0.00%> (-0.02%) ⬇️
elasticsearch-6.x-v1 20.77% <ø> (ø)
elasticsearch-7.x-v1 20.85% <ø> (ø)
elasticsearch-8.x-v1 21.03% <ø> (ø)
elasticsearch-8.x-v2 1.89% <0.00%> (-0.02%) ⬇️
grpc_v1 11.38% <ø> (ø)
grpc_v2 1.89% <0.00%> (-0.02%) ⬇️
kafka-3.x-v1 10.20% <ø> (ø)
kafka-3.x-v2 1.89% <0.00%> (-0.02%) ⬇️
memory_v2 1.89% <0.00%> (-0.02%) ⬇️
opensearch-1.x-v1 20.90% <ø> (ø)
opensearch-2.x-v1 20.90% <ø> (ø)
opensearch-2.x-v2 1.89% <0.00%> (-0.02%) ⬇️
query 1.89% <0.00%> (-0.02%) ⬇️
tailsampling-processor 0.52% <0.00%> (-0.01%) ⬇️
unittests 95.00% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Manik2708
Copy link
Contributor Author

@yurishkuro These are the metrics being generated
new_Es.txt

@Manik2708
cleanup
5f2cdfe 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
graphite-app[bot]
graphite-app bot reviewed Jun 5, 2025
View reviewed changes
@Manik2708 Manik2708 requested a review from yurishkuro June 5, 2025 10:01
Manik2708 added 2 commits June 12, 2025 13:42
@Manik2708
cleanup
d246514 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708
Merge branch 'main' into metrics
2ab5321
@Manik2708 Manik2708 requested a review from yurishkuro June 12, 2025 08:13
@yurishkuro yurishkuro changed the title [v2] Implement metrics decorator for trace reader [es/v2] Add metrics decorator for trace reader Jun 13, 2025
@Manik2708
cleanup
38177c8 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708 Manik2708 requested a review from yurishkuro June 13, 2025 08:07
@yurishkuro yurishkuro added this pull request to the merge queue Jun 13, 2025
Merged via the queue into jaegertracing:main with commit cbe7526 Jun 13, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
area/storage changelog:bugfix-or-minor-feature storage/elasticsearch v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: There are no metrics from jaeger_storage exporter
2 participants
@Manik2708 @yurishkuro