[ES] Make NestedTags and ElevatedTags distinction at CoreSpanReader level
#7067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7067 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 355 355
Lines 20993 21000 +7
=======================================
+ Hits 20156 20163 +7
Misses 630 630
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Apr 23, 2025
yurishkuro
reviewed
Apr 24, 2025
yurishkuro
reviewed
Apr 24, 2025
yurishkuro
approved these changes
Apr 27, 2025
Merged
via the queue into
jaegertracing:main
with commit Apr 27, 2025
c3f8f21
57 of 58 checks passed
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…der` level (jaegertracing#7067) ## Which problem is this PR solving? - Fixes a part of: jaegertracing#7034 ## Description of the changes - Make `NestedTags` and `ElevatedTags` distinction at `CoreSpanReader` level and a follow-up PR for jaegertracing#6946 ## How was this change tested? - Unit And Integration Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…der` level (jaegertracing#7067) ## Which problem is this PR solving? - Fixes a part of: jaegertracing#7034 ## Description of the changes - Make `NestedTags` and `ElevatedTags` distinction at `CoreSpanReader` level and a follow-up PR for jaegertracing#6946 ## How was this change tested? - Unit And Integration Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <mehtamanik96@gmail.com> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
NestedTagsandElevatedTagsdistinction atCoreSpanReaderlevel and a follow-up PR for [ES] MakeNestedTagsandFieldTagsdistinction atCoreSpanWriterlevel #6946How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test