Skip to content

fix(hotrod): include CA certificates for HOTRod Dockerfile #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix(hotrod): include CA certificates for HOTRod Dockerfile #6627

merged 2 commits into from
Jan 28, 2025

Conversation

prashant-shahi
Copy link
Contributor

@prashant-shahi prashant-shahi commented Jan 28, 2025 •
edited by yurishkuro
Loading

Which problem is this PR solving?

Description of the changes

  • includes CA Certificates to the HOTRod image

How was this change tested?

  • Tested with secured endpoint of upstream collector

Checklist

@prashant-shahi prashant-shahi requested a review from a team as a code owner January 28, 2025 10:19
@dosubot dosubot bot added the docker Pull requests that update Docker code label Jan 28, 2025
@prashant-shahi prashant-shahi changed the title fix(hotrod): include CA certificates for HOTRod docker images fix(hotrod): include CA certificates for HOTRod Dockerfile Jan 28, 2025
@prashant-shahi
fix(hotrod): include CA certificates for HOTRod docker images
c2d03c2 
Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
yurishkuro
yurishkuro reviewed Jan 28, 2025
View reviewed changes
@prashant-shahi
chore(hotrod): update Dockerfile
290b95e 
Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
@yurishkuro yurishkuro enabled auto-merge (squash) January 28, 2025 20:16
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (20bdd8d) to head (290b95e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6627      +/-   ##
==========================================
+ Coverage   96.00%   96.03%   +0.02%     
==========================================
  Files         365      365              
  Lines       20616    20616              
==========================================
+ Hits        19792    19798       +6     
+ Misses        626      622       -4     
+ Partials      198      196       -2
Flag Coverage Δ
badger_v1 9.92% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 15.08% <ø> (ø)
cassandra-4.x-v2-auto 1.83% <ø> (ø)
cassandra-4.x-v2-manual 1.83% <ø> (ø)
cassandra-5.x-v1-manual 15.08% <ø> (ø)
cassandra-5.x-v2-auto 1.83% <ø> (ø)
cassandra-5.x-v2-manual 1.83% <ø> (ø)
elasticsearch-6.x-v1 19.30% <ø> (ø)
elasticsearch-7.x-v1 19.38% <ø> (ø)
elasticsearch-8.x-v1 19.56% <ø> (ø)
elasticsearch-8.x-v2 1.84% <ø> (-0.12%) ⬇️
grpc_v1 11.04% <ø> (ø)
grpc_v2 7.89% <ø> (ø)
kafka-3.x-v1 10.21% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.84% <ø> (ø)
opensearch-1.x-v1 19.44% <ø> (ø)
opensearch-2.x-v1 19.44% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.84% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro disabled auto-merge January 28, 2025 20:37
@yurishkuro yurishkuro merged commit 9d3a516 into jaegertracing:main Jan 28, 2025
54 of 55 checks passed
@prashant-shahi prashant-shahi deleted the fix/ca-certificates branch January 29, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@mahadzaryab1 mahadzaryab1 Awaiting requested review from mahadzaryab1 mahadzaryab1 is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: unable to send data from HOTRod to secured endpoint
2 participants
@prashant-shahi @yurishkuro