Skip to content

replace all imports of jaeger/thrift-gen/* with jaeger-idl/thrift-gen/* #6621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2025
Merged

replace all imports of jaeger/thrift-gen/* with jaeger-idl/thrift-gen/* #6621

merged 3 commits into from
Jan 28, 2025

Conversation

danish9039
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • replace all imports of jaeger/thrift-gen/* with jaeger-idl/thrift-gen/*

How was this change tested?

  • make lint test

Checklist

@danish9039
replace all imports of jaeger/thrift-gen/* with jaeger-idl/thrift-gen/*
8f2f05e 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner January 27, 2025 11:39
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (20bdd8d) to head (57e54dd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6621      +/-   ##
==========================================
- Coverage   96.00%   95.97%   -0.03%     
==========================================
  Files         365      365              
  Lines       20616    20616              
==========================================
- Hits        19792    19787       -5     
- Misses        626      630       +4     
- Partials      198      199       +1
Flag Coverage Δ
badger_v1 9.92% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 15.08% <ø> (ø)
cassandra-4.x-v2-auto 1.83% <ø> (ø)
cassandra-4.x-v2-manual 1.83% <ø> (ø)
cassandra-5.x-v1-manual 15.08% <ø> (ø)
cassandra-5.x-v2-auto 1.83% <ø> (ø)
cassandra-5.x-v2-manual 1.83% <ø> (ø)
elasticsearch-6.x-v1 19.30% <ø> (ø)
elasticsearch-7.x-v1 19.38% <ø> (ø)
elasticsearch-8.x-v1 19.56% <ø> (ø)
elasticsearch-8.x-v2 1.84% <ø> (-0.12%) ⬇️
grpc_v1 11.04% <ø> (ø)
grpc_v2 7.89% <ø> (ø)
kafka-3.x-v1 10.21% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.84% <ø> (ø)
opensearch-1.x-v1 19.44% <ø> (ø)
opensearch-2.x-v1 19.44% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.79% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danish9039
...
57e54dd 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
yurishkuro
yurishkuro approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@yurishkuro yurishkuro merged commit 98d67ab into jaegertracing:main Jan 28, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danish9039 @yurishkuro