-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
enhancementgood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement
Description
The jaeger-idl now has a copy of thrift-gen types. We want to remove jaeger's dependency on jaeger/thrift-gen in favor of jaeger-idl/thrift-gen,
- fix(deps): update github.com/jaegertracing/jaeger-idl digest to c9efb29 #6605
- remove auto-generated code and replace its types / functions with aliases to jaeger-idl hosted types (see Redefine model/ and api_v2/ types as aliases to jaeger-idl/ types #6602 for similar change for proto types)
- replace all imports of
jaeger/thrift-gen/*
withjaeger-idl/thrift-gen/*
(similar to Replace model imports with jaeger-idl #6595) - migrate
samping.thrift
to jaeger-idl similar to above - remove
baggage.thrift
code-gen steps and code, as it is unused - remove Thrift generation from
jaeger
repo altogether
Metadata
Metadata
Assignees
Labels
enhancementgood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement