Replace APIv2 with APIv3 client in e2e tests #6424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
=======================================
Coverage 96.24% 96.25%
=======================================
Files 368 368
Lines 20977 20978 +1
=======================================
+ Hits 20189 20192 +3
+ Misses 603 602 -1
+ Partials 185 184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <github@ysh.us>
mahadzaryab1
approved these changes
Dec 28, 2024
Co-authored-by: Mahad Zaryab <43658574+mahadzaryab1@users.noreply.github.com> Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
## Which problem is this PR solving? - Resolves jaegertracing#6422 ## Description of the changes - Replace span_reader (api_v2 gRPC client) with trace_reader (api_v3 gRPC client) - Set ingester logs to `info` because `kafkareceiver` logs the binary content of the messages via `debug` - Move logic related to child process into `binary.go` - Preserve original config file name for readability when modifying it to add storage cleaner extension - Add timeout to `writeTrace()` - Bumped into a subtle issue that if Cmd.Env is not nil then the sub-process does not inherit any other env from the parent, which was causing issues with Kafka tests where we pass topic & encoding via env, but for V2 Reader I had to add another env to disable self-tracing. Changed this to always pass EnvOverrides directly via Cmd.Env instead of setting them on the parent process. ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Mahad Zaryab <43658574+mahadzaryab1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
infobecausekafkareceiverlogs the binary content of the messages viadebugbinary.gowriteTrace()How was this change tested?