Add grpc-gateway tests for all APIv3 methods #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
9703430 to
161e6a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
==========================================
- Coverage 95.53% 95.53% -0.01%
==========================================
Files 313 313
Lines 18161 18160 -1
==========================================
- Hits 17350 17349 -1
Misses 649 649
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
commented
Dec 27, 2023
| t.Run("FindTraces", func(t *testing.T) { | ||
| runGatewayFindTraces(t, gw, setupRequest) | ||
| }) | ||
| } |
There was a problem hiding this comment.
@albertteoh this was the point of cleaning up tests - now they are testing all gateway APIs and we can try things like upgrading the gateway dep to v2.x or completely re-implementing it. My next step would be to try an upgrade, which requires building a new protoc image that I just kicked off (takes 4hrs to build), and maybe with v2 gateway we could find a way to integrate gogo marshaling.
5 tasks
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
This was referenced Dec 28, 2023
yurishkuro
added a commit
that referenced
this pull request
Dec 30, 2023
## Which problem is this PR solving? - Part of #5052 ## Description of the changes - Pull in IDL change jaegertracing/jaeger-idl#102 - Re-implement APIv3 HTTP endpoints without the use of grpc-gateway - Share tests from grpc-gateway for manual implementation - Refactor tests to avoid duplication of snapshots - Fix inconsistency between http and grpc tenancy interceptors where HTTP was returning Unauthenticated in certain cases, but GRPC was always returning Forbidden. Make them consistent: missing tenant header results in Unauthenticated. ## Follow-ups - [x] http implementation needs more unit tests (mostly error handling and parameter variations) - [ ] the new implementation is not hooked up into production code yet, I first want to confirm it works with model-v2, and just in general minimize the scope of a single PR ## How was this change tested? - Using unit tests added in #5051, with additional enhancements --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Gaps
How was this change tested?