-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Description
Per Jaeger v2 design doc, we need to have our internal copy of code-generated Proto types for OTLP data model (because OTel Collector keeps it private). My current experiments in https://github.com/yurishkuro/jaeger/tree/otel-proto-gogo ran into an issue with grpc-gateway that already uses internally built OTLP protos, but without Gogo optimizations.
Plan of action
- Upgrade grpc-gateway to v2
- clean up tests Clean-up APIv3 tests #5046
- add tests for all API v3 methods to ensure stable JSON output Add grpc-gateway tests for all APIv3 methods #5051
- Try to use v2 gateway with gogoproto marshaling
- if it does not work, consider reimplementing the gateway manually, it's only 4 functions in the API. It will also be more efficient since we won't need to do a roundtrip to the gRPC service.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done