Define import path in preparation of repository move to jaegertracing #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprithvi
reviewed
Sep 20, 2017
| return err | ||
| } | ||
| return nil | ||
| return vFunc(request, traces) |
There was a problem hiding this comment.
These seem to be changes unrelated to this PR.
There was a problem hiding this comment.
Because go vet complained
vprithvi
approved these changes
Sep 20, 2017
black-adder
reviewed
Sep 20, 2017
| @@ -1,6 +1,7 @@ | |||
| sudo: required | |||
|
|
|||
| language: go | |||
| go_import_path: github.com/uber/jaeger | |||
There was a problem hiding this comment.
just so I'm on the same boat, why is this required?
There was a problem hiding this comment.
after the repo move the github path is going to be different, but all the imports in the code refer to uber/jaeger, so it won't build. This instruction tells Travis to relocate the repo to this path under GOPATH before building.
black-adder
approved these changes
Sep 20, 2017
ideepika
pushed a commit
to ideepika/jaeger
that referenced
this pull request
Oct 22, 2017
isaachier
pushed a commit
to isaachier/jaeger
that referenced
this pull request
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://github.com/uber/jaeger/issues/409