Zipkin json and thrift xdock tests #378
Conversation
| if a.Host != nil && a.Host.ServiceName != "" { | ||
| return a.Host.ServiceName, a.Host.Ipv4, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
if you're adding this you obviously ran into an issue, but I am curious that kind of binary annotation (aside from LOCAL_COMPONENT already checked for above) could be considered a reliable source of service name/ip?
NB a comment above this loop would be good explaining.
There was a problem hiding this comment.
I have added a comment, basically tracer can send a span with just one binary annotation, see also liked issue it happened with correct OT instrumentation and brave-opentracing.
|
test seems to fail with |
|
looks great if we can get it to work! |
It was late I forgot to push the latest image. Now it should work. |
crossdock/docker-compose.yml
Outdated
| @@ -9,6 +9,8 @@ services: | |||
| - node | |||
| - java | |||
| - python | |||
| - zipkin-brave-json | |||
| - zipkin-brave-thrift | |||
|
|
|||
| environment: | |||
| - WAIT_FOR=test_driver,go,node,java,python | |||
There was a problem hiding this comment.
we should wait for zipkin-brave-json/zipkin just in case (assuming they have a health check endpoint)
| @@ -178,6 +178,12 @@ func (td toDomain) findServiceNameAndIP(zSpan *zipkincore.Span) (string, int32, | |||
| return a.Host.ServiceName, a.Host.Ipv4, nil | |||
| } | |||
| } | |||
| // Tracer can also report a span witch just binary annotation | |||
d5a5f9d to
f285fd1
Compare
|
The repo has been moved to https://github.com/jaegertracing/xdock-zipkin-brave |
|
this should be ready for re-review/merge. |
Fixes #181 #337.
It uses https://hub.docker.com/r/pavolloffay/xdock-zipkin-brave/ with https://github.com/pavolloffay/xdock-zipkin-brave/pull/1/files. Once this is approved I will move it to jaegertracing.