-
Notifications
You must be signed in to change notification settings - Fork 558
Fix deferreturn and bolt #11594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix deferreturn and bolt #11594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
May 18, 2020
|
|
howbazaar
reviewed
May 18, 2020
|
2 similar comments
|
|
Merged
jujubot
added a commit
that referenced
this pull request
May 19, 2020
#11600 ## Description of change Merge 2.8-rc branch with these commits: #11585 don't write errors when pubsub socket disconnects #11583 k8s pod initialisaton races #11582 increase max wait time for WaitAdance #11573 finish legacy lease removal #11591 increase timeout in machine agent tests #11592 expose engine worker restart time as package variable #11507 add k8s model agent pod #11595 fix caas uniter restart on error #11593 add revoke leases so dead units lose their lease immediately #11594 fix deferreturn and bolt #11599 update deployment name used for model op ## QA steps See individual PRs.
Merged
jujubot
added a commit
that referenced
this pull request
May 19, 2020
#11604 ## Description Merge 2.8 branch with these commits: #11585 don't write errors when pubsub socket disconnects #11583 k8s pod initialisaton races #11582 increase max wait time for WaitAdance #11573 finish legacy lease removal #11591 increase timeout in machine agent tests #11592 expose engine worker restart time as package variable #11507 add k8s model agent pod #11595 fix caas uniter restart on error #11593 add revoke leases so dead units lose their lease immediately #11594 fix deferreturn and bolt #11599 update deployment name used for model op ## QA Se individual PRs
jujubot
added a commit
that referenced
this pull request
Jun 4, 2020
…t-least-384-bytes-long #11660 ## Description of change This PR lands a number of changes to unblock our CI. More specifically: - Go will not allow TLS handshakes with TLS1.2+ if key is 64 bytes long. This PR removes the PatchValue calls from the various test suites that forced a 512bit key length so that all our tests use the preferred (384 byte long) default key size. - In addition, this PR cherry-picks a commit from #11632 to fetch a snapshot of the vendor folder from S3 and includes additional commits to bypass 'dep ensure' (which is called multiple times by the various Makefile targets) when using the cached deps. - Finally, the PR backports the fixes from #11654 and #11594.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
QA steps
Documentation changes
N/A
Bug reference
https://golang.org/issue/39049
etcd-io/bbolt#201