Update automator exclude check to exclude files in PR causing event #3427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
reviewed
Jul 8, 2021
tools/automator/automator.sh
Outdated
| if [ -n "$git_exclude" ]; then | ||
| pr="$(curl -sSfLH "Authorization: token $token" -H "Accept: application/vnd.github.groot-preview+json" "https://api.github.com/repos/$user/$repo/commits/$sha/pulls" | jq ".[0].number")" | ||
| export GITHUB_TOKEN="$token" | ||
| changes=$(gh pr view "$pr" --repo "$user"/"$repo" --json files | jq -r '.files[].path' | grep -cvE '$git_exclude') |
There was a problem hiding this comment.
Why do we need to look at the PR instead of the commit locally? Aren't they the same?
There was a problem hiding this comment.
If we always expect the PR to be squashed, then we should be able to look at the last commit. I recall some issues with git diff-tree in the past. I can try just using git show --name-only.
There was a problem hiding this comment.
@howardjohn Changed implementation to use files for the most recent commit. Format it name only with a one-liner as the header removed with the sed. Then the grep will remove the specified lines. If any changes are left, the job continues. Else ends.
|
LGTM overall, just one thing I didn't fully understand about the implementation |
brian-avery
reviewed
Jul 9, 2021
|
This LGTM, but will let @howardjohn provide the approval. |
|
@howardjohn Any other comments on this? |
howardjohn
approved these changes
Jul 12, 2021
|
@ericvn: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
soloio-bot
pushed a commit
to soloio-bot/test-infra
that referenced
this pull request
Jun 22, 2023
* Add periodic job to update the istio reference used by istio.io tests (istio#3184) * Add periodic job to update the istio reference used by istio.io tests * Remove auto-merge for now as tests are not required to hold out PR. * Change day to Sunday * Bump prow from v20210206-3c06bdc6cf to v20210215-f94bc1dc87 (istio#3183) * Allow configuring Annotations and Labels fields for Prow job config (istio#3186) * Remove gerrit report label for Prow jobs that do not need to report (istio#3187) * Drop Kubernetes 1.15 job (istio#3189) Part of istio/istio#30822, per approval of T&R and Upgrade WG * Fix one small issue of the genjobs tool (istio#3191) * Update `make gen` to also do go formatting (checks format on PR) (istio#3185) * Rin gofumpt on prow/config/generate_test.go (istio#3192) * Automator: update common-files@master in istio/test-infra@master (istio#3175) * Bump prow from v20210215-f94bc1dc87 to v20210222-37d809a6d8 (istio#3188) * Manual update build-tools:master (istio#3193) * Change Envoy auto-updates to daily schedule. (istio#3197) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Bump k8s 1.21 to beta0 (istio#3196) * Automator: update common-files@master in istio/test-infra@master (istio#3198) * Automator: update common-files@master in istio/test-infra@master (istio#3199) * Automator: update common-files@master in istio/test-infra@master (istio#3201) * Automator: update build-tools:master (istio#3200) * Bump prow from v20210222-37d809a6d8 to v20210301-5e63448d42 (istio#3194) * Automator: update common-files@master in istio/test-infra@master (istio#3202) * Automator: update build-tools:master (istio#3203) * Some updates and fixes to the genjobs tools (istio#3205) * Automator: update common-files@master in istio/test-infra@master (istio#3207) * Bump prow from v20210301-5e63448d42 to v20210305-64a6d4d83a (istio#3204) * Add github to release builder build job (create PR if new base images) (istio#3211) * Add labels to specify merge type for a repo (istio#3213) * Switch autobumper to generic autobump (istio#3214) * Automator: update common-files@master in istio/test-infra@master (istio#3217) * Prow config generator supports interval and cron overwrite (istio#3215) * Automator: update build-tools:master (istio#3218) * Update Prow to v20210315-198593ae42 (istio#3212) * Automator: update build-tools:release-1.9 (istio#3216) * Make doc tests required for release-1.9 (istio#3223) * Added a prow job for automatic merging of upstream changes into 1.9 envoy release branch (istio#3219) * Added a prow job for automatic merging of upstream changes into 1.9 envoy release branch Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Fixing the build * Fixing build failures * Removed auto-merge label * Update prow plugins to new form (istio#3220) * Update prow plugins to new form * Also delete TestPlugins test as it's already covered by pull-test-infra-prow-checkconfig * Istio prow: upgrade prometheus operator from 0.29.0 to 0.45.0 (istio#3225) This was based on kubernetes/test-infra#21291 * Prow monitoring: deploy CRDs before mixins (istio#3226) * Update Prow to v20210322-23ade8ba07 (istio#3221) * Added a merge workflow to automator.sh script (istio#3228) * added a merge workflow to automator.sh script Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Fixed issues picked up by the linter * Bump pyyaml from 5.1.1 to 5.4 (istio#3233) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.1.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.1.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Renaming testgrid/default.yaml to testgrid/config.yaml (istio#3234) * Fix usage in prow job for testgrid transfigure (istio#3235) * Make istio.io doc tests required (istio#3232) * Make istio.io doc tests required * Add tag to transfigure job * Switched merging of upstream changes for 1.9 release to use the 'merge' automator workflow (istio#3230) * Update Prow to v20210329-38365dd4a8 (istio#3227) * Switched to a plain string for the upstream branch name (istio#3236) Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Removed double-quotes from the merge-branch parameter (istio#3238) * Fix release 1.9 centos build image. (istio#3239) * Remove docker and entrypoint from centos job. (istio#3240) * automator - Add option to exclude file/path on git diff (istio#3231) * Automator: update common-files@master in istio/test-infra@master (istio#3242) * Update Prow to v20210404-ef7abaaa70 (istio#3237) * Add enhancements repo (istio#3245) * Update config.yaml * Add tide while I'm here * Automator: update build-tools:master (istio#3243) * Add branch protection for release-1.10 (istio#3247) * Add release-1.10 Prow job configs (istio#3249) * Add prow job config for release-1.10 branches * Add dashboard configs for release-1.10 * Fix build-tools to reference release-1.10 rather than master * Automator: update common-files@master in istio/test-infra@master (istio#3250) * Automator: update common-files@master in istio/test-infra@master (istio#3251) * Update base image (istio#3253) * Automator: update build-tools:release-1.10 (istio#3252) * Update update-images.sh (istio#3254) * Fix master branch common files (istio#3259) * Bump kubernetes jobs (istio#3258) Move 1.21 to RC Add 1.22 * Automator: update build-tools:release-1.9 (istio#3256) * Automator: update build-tools:release-1.8 (istio#3257) * Automator: update build-tools:master (istio#3255) * Automator: update common-files@master in istio/test-infra@master (istio#3260) * Prow config generator supports configuring annotations with requirements (istio#3222) * Update presets for 1.8 1.9 and 1.10 (istio#3261) * And the other half (istio#3262) * Add API (istio#3263) * Add API * Change 1.4 configmap to master * Add a postsubmit job for CNI (istio#3265) * Add post submit job for CNI. * fix * gen * Unhide 1.21+ jobs and use stable release (istio#3266) These are stable now * Add github-optional (istio#3267) * Add github-optional * Fixed config and reran make gen * Remove outdated code. Doesn't influence cluster gen * Update periodic update of istio test ref in istio.io to 1.10. (istio#3268) * Update latest k8s for tests, move 1.21 postsubmit tp 1.20 for coverage (istio#3270) 1.21 is covered in pre-submit. * Update the kind images to latest for testing. 1.20 done by presubmit. (istio#3271) * Update Prow to v20210412-ed35ec0cee (istio#3246) * Automator: update common-files@master in istio/test-infra@master (istio#3274) * Automator: update build-tools:master (istio#3273) * Istio prow: deck use workload identity (istio#3275) * Hot fix workload identity annotation for deck sa (istio#3276) * Prow components use RBAC and workload identity (istio#3277) Pretty much copy/pasted from k8s/test-infra * Hot fix: add part-of: prow label to all newly added rbac (istio#3279) * Add prefixes private repos (istio#3278) * Add presets * Add private jobs * Update presets * Change secret to configmap (istio#3280) * Change /Users/testuser to /home (istio#3281) * Add private jobs for 1.10 (istio#3282) * Envoy too (istio#3283) * Add envoy-1.10 jobs (istio#3284) * Add envoy-1.10 jobs * Add testgrid changes * Unhide 1.21 integration test for 1.10 (istio#3285) * Update Envoy images (istio#3286) * Update Prow to v20210419-8262f2d0c6 (istio#3272) * Delete unused tot resources (istio#3289) * Use explicit github-token-path flag (istio#3290) * Automator: update build-tools:release-1.10 (istio#3291) * Add periodic job to for envoy-1.10 from envoy-1.9 (istio#3292) * Add periodic job to for envoy-1.10 from envoy-1.9 * Add dashboard * Remove periodic envoy job which inadvertantly got merged. (istio#3294) * Disable RBE in 1.5/1.6 private (istio#3296) * Add periodic job to istio/proxy 1.10 branch to get latest envoy 1.18 … (istio#3297) * Add periodic job to istio/proxy 1.10 branch to get latest envoy 1.18 commit * Update dashboard name * Disable release notes job in private repo (istio#3298) Cannot run it here * Automator: update common-files@master in istio/test-infra@master (istio#3300) * Automator: update build-tools:release-1.9 (istio#3301) Co-authored-by: istio-testing <istio-testing-bot@google.com> * Istio prow: enable secret managed by kubernetes external secrets (istio#3244) * Istio prow: enable secret managed by kubernetes external secrets This was enabled in upstream and working: https://github.com/kubernetes/test-infra/blob/master/prow/prow_secrets.md * KES uses workload identity * Add prow label to kes so they are deployed * automator.sh now creates tickets in istio/istio on failed merges (istio#3303) * automator.sh now creates tickets in istio/istio on failed merges Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Responded to feedback Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Actually removed gh login auth Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Update Prow to v20210426-51fd28eca9 (istio#3295) * Add a CNI presubmit test job. (istio#3302) * Don't fail automator's merge workflow if there's a merge conflict (istio#3305) Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Update Prow to v20210502-ba10239e8c (istio#3304) * temporary jobs for istiodless remotes (istio#3310) * fix istiodless flag (istio#3311) * Automator: update build-tools:release-1.9 (istio#3312) * Automator: update common-files@master in istio/test-infra@master (istio#3314) * Update CNI test job to use CNI enablement flag. (istio#3315) * Update CNI test job to use CNI enablement flag. * gen * Fixed istio repository name where new issues are created (istio#3316) Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> * Add netrc (istio#3318) * More presets (istio#3319) * Automator: update common-files@master in istio/test-infra@master (istio#3321) * Enable Google Analytics for prow.istio.io. (istio#3323) * Automator: update build-tools:master (istio#3320) * Update Prow to v20210510-9df9f3186f (istio#3313) * Automator: update build-tools:release-1.10 (istio#3317) * Automator: update build-tools:release-1.9 (istio#3322) * Make centos job required (istio#3325) * Release notes validation (istio#3327) * compile schema-validator (istio#3328) * Add istio/client-go, istio/pkg and istio/gogo-genproto to list of automator jobs (istio#3209) * Add istio/client-go, istio/pkg and istio/gogo-genproto to list of automator jobs * Run make generate-config * Exclude common directory in automator * Run make gen * Update Prow to v20210515-9461f01d36 (istio#3324) * add schema validation (istio#3326) * add schema validation * Run make gen * Update testgrid * Make enhancements job optional (istio#3329) * Convert args to use equals instead of space (istio#3331) * Fix arg (istio#3332) * Automator: update common-files@master in istio/test-infra@master (istio#3333) * Automator: update build-tools:master (istio#3334) * Istio prow: switch grafana password to be from external secret (istio#3335) * Automator: update build-tools:master (istio#3337) * Automator: update common-files@master in istio/test-infra@master (istio#3338) * Automator: update common-files@master in istio/test-infra@master (istio#3340) * Automator: update build-tools:master (istio#3339) * Revert to the exact image we had before (istio#3341) A desperate attempt to fix istio/istio#32985 * Isolate multicluster jobs (istio#3343) I have seen cases where we have 3 multicluster jobs on a node, so 9 k8s. The node ends up pinned at 100% cpu the whole time which may be causing flakes. With this change, we can get the following arangements of jobs: * 3 non-mc jobs (unchanged) * 1 mc job and 1 non-mc job * Multiple distinct gcr.io/k8s-prow/ changes: (istio#3330) Commits | Dates | Images --- | --- | --- kubernetes/test-infra@9461f01...cf0aabd | 2021‑05‑15 → 2021‑05‑24 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Add a periodic job to assist in measuring test stability (istio#3344) * Add a periodic job to assist in measuring test stability * add testgrid * Update master istio.io automated job to use master istio repo. (istio#3345) * Add periodic tests for dedicated n2 and e2 nodes (istio#3347) * Update common-files and fix lint failure (istio#3350) * Automator: update common-files@master in istio/test-infra@master (istio#3351) * Automator: update build-tools:master (istio#3349) * Skip release test (istio#3352) Desperate attempt to see if this improves istio/istio#32985 I may be seeing things but it feels like there is a pattern: istio/istio#32985 (comment) * Automator: update common-files@master in istio/test-infra@master (istio#3353) * Automator: update common-files@master in istio/test-infra@master (istio#3355) * Automator: update build-tools:master (istio#3354) * Revert "Skip release test (istio#3352)" (istio#3356) This reverts commit e904b07. * Disable go cache (istio#3357) Wild attempt... I did see in the logs of one node "device is unavailable" for build cache, and it is something that is persistent on nodes, so it seems *plausibly* related. We will revert if not * Pin IPv6 jobs to ubuntu nodes (istio#3359) * Pin IPv6 jobs to ubuntu nodes This will allow us to add COS nodes without breaking ipv6 * fix dupe key * Revert "Disable go cache (istio#3357)" (istio#3360) This reverts commit ab54fa7. * Undo some changes to test regression (istio#3361) * Cleanup periodic test jobs * Put ipv6 on a new node pool, so we can remove the ubuntu one and ensure ONLY ipv6 uses it * Automator: update common-files@master in istio/test-infra@master (istio#3362) * Automator: update build-tools:master (istio#3363) * Automator: update common-files@master in istio/test-infra@master (istio#3364) * Automator: update build-tools:master (istio#3365) * Bumping Prow (istio#3346) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@cf0aabd...03cf33d | 2021‑05‑24 → 2021‑05‑31 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * update perf test jobs to 1.10 (istio#3369) * Make Authentikos log token creation error messages. (istio#3370) * Make Authentikos log token creation error messages. * Add error handling to authentikos unit tests to figure out why this is failing in CI. * Remove test case for unreadable template file that doesn't pass when run as root. * Update go.mod for k8s/test-infra (istio#3371) * Update go.mod for k8s/test-infra * Pin pprof for licensing issue * Publish Authentikos version 0.0.7 (istio#3372) * Postsubmit prow deploy job automatically sends slack notifications (istio#3373) This was pretty much a copy of https://github.com/kubernetes/test-infra/blob/aee86026c87da353a8c5b14f5b3fe80bcb820212/config/jobs/kubernetes/test-infra/test-infra-trusted.yaml#L102, which had been working pretty well for k8s/test-infra based on https://testgrid.k8s.io/istio_test-infra_postsubmit#deploy-prow_test-infra_postsubmit, this shouldn't happen very frequently, for now it's only once per week * Fix DNS issue with kind in Authentikos integration tests by upgrading kind node version. (istio#3374) * fix authentikos integ test (istio#3342) * fix authentikos integ test * capture exit code from run_test * Authentikos prints md5sum of generated token for debug purpose (istio#3376) * Authentikos: support using real token expiration time instead of hard coded 3600s (istio#3375) * Automator: update build-tools:release-1.9 (istio#3377) * Authentikos version bump to 0.0.8 (istio#3378) * Bumping Prow (istio#3367) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@03cf33d...a3457f6 | 2021‑05‑31 → 2021‑06‑07 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update common-files@master in istio/test-infra@master (istio#3380) * Automator: update build-tools:master (istio#3381) * Automator: update common-files@master in istio/test-infra@master (istio#3383) * Automator: update build-tools:master (istio#3382) * bump kubernetes versions (istio#3384) * Remove private patch (istio#3385) * Update build-tools and build-tools-centos images. (istio#3387) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update to use first commit's parent sha to find file differences (istio#3386) * Automator: update common-files@master in istio/test-infra@master (istio#3388) * Fix gogo-gen automator job - update repo name (istio#3390) * Automated merging of prow bumping PRs (istio#3391) * Automator: update build-tools:release-1.10 (istio#3392) * Automator: update build-tools:master (istio#3389) * Bumping Prow (istio#3379) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@a3457f6...1938066 | 2021‑06‑07 → 2021‑06‑16 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3393) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@1938066...a5d241a | 2021‑06‑16 → 2021‑06‑17 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update common-files@master in istio/test-infra@master (istio#3396) * Unhide CNI presubmit jobs. (istio#3394) * Automator: update common-files@master in istio/test-infra@master (istio#3397) * Bumping Prow (istio#3395) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@a5d241a...4b498df | 2021‑06‑17 → 2021‑06‑17 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3398) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@4b498df...762366a | 2021‑06‑17 → 2021‑06‑22 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3400) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@762366a...0c619ad | 2021‑06‑22 → 2021‑06‑23 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3401) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@0c619ad...f668b08 | 2021‑06‑23 → 2021‑06‑25 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3403) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@f668b08...e1bdf10 | 2021‑06‑25 → 2021‑06‑25 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update common-files@master in istio/test-infra@master (istio#3407) * Bumping Prow (istio#3404) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@e1bdf10...e1fb22e | 2021‑06‑25 → 2021‑06‑28 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update build-tools:master (istio#3406) * Automator: update common-files@master in istio/test-infra@master (istio#3410) * Bumping Prow (istio#3408) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@e1fb22e...03ae97a | 2021‑06‑28 → 2021‑06‑29 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3411) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@03ae97a...419533b | 2021‑06‑29 → 2021‑07‑01 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update common-files@master in istio/test-infra@master (istio#3415) * Automator: update build-tools:master (istio#3414) * Revert "Automator: update build-tools:master (istio#3414)" (istio#3416) This reverts commit 2aa2755. * Add periodic job for security fuzz tests (istio#3409) * add a postsubmit job for security fuzz tests * make generate-config * change to daily job * use new pattern * make gen * add istio_istio_periodic dashboard * Bumping Prow (istio#3412) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@419533b...3efe91b | 2021‑07‑01 → 2021‑07‑01 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Explicitly define slack report config in each job (istio#3399) * Bumping Prow (istio#3417) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@3efe91b...728bc30 | 2021‑07‑01 → 2021‑07‑05 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Bumping Prow (istio#3418) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@728bc30...6238fe3 | 2021‑07‑05 → 2021‑07‑05 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update common-files@master in istio/test-infra@master (istio#3423) * Automator: update build-tools:release-1.10 (istio#3419) * Automator: update build-tools:master (istio#3422) * Bumping Prow (istio#3420) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@6238fe3...3e989f6 | 2021‑07‑05 → 2021‑07‑07 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Some updates to the Prow configgen tool (istio#3426) * Bumping Prow (istio#3425) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@3e989f6...32dc49e | 2021‑07‑07 → 2021‑07‑07 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Generation of istio-private jobs. (istio#3421) * still need make gen, but did rebase * Break transform and job configs into mirror programs * Lets clean up private as well * Fix copyright * Deny benchmark-report_istio_postsubmit_priv in istio-private * Automator: update common-files@master in istio/test-infra@master (istio#3429) * Update automator exclude check to exclude files in PR causing event (istio#3427) * Update automator exclude check to exclude files in PR causing event * Fix repo and org in commands * Change to just look at files in last commit (assumes squashed) * Fix unbound variable * Update readme to use prior commit instead of PR * Change function name and add description * Bumping Prow (istio#3428) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@32dc49e...f6f2d39 | 2021‑07‑07 → 2021‑07‑12 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Automator: update build-tools:master (istio#3432) * Automator: update common-files@master in istio/test-infra@master (istio#3433) * Automator: update common-files@master in istio/test-infra@master (istio#3434) * Automator: update build-tools:master (istio#3435) * Automator: update common-files@master in istio/test-infra@master (istio#3437) * Automator: update build-tools:master (istio#3436) * Automator: update build-tools:release-1.9 (istio#3424) * Bumping Prow (istio#3431) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@f6f2d39...49f933a | 2021‑07‑12 → 2021‑07‑13 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * Restore api dep update on client-go in all cases (istio#3439) * Restore api dep update on client-go in all cases * Run make gen * Automator: update build-tools:release-1.10 (istio#3438) * Add branch protection to 1.11 (istio#3430) * Add jobs for 1.11 (istio#3442) * Add jobs for 1.11 * Add private jobs * Add testgrid * Fix automator script failing on exit code of 1 from grep (istio#3440) * Workaround prow library limitations to properly hide jobs (istio#3443) * Workaround prow library limitations to properly hide jobs * 1.11 * Bumping Prow (istio#3441) Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@49f933a...ac233fa | 2021‑07‑13 → 2021‑07‑14 | branchprotector, checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide, transfigure * more merge conflicts * update files * remove reporter * make gen Co-authored-by: Eric Van Norman <ericvn@us.ibm.com> Co-authored-by: Istio Automation <istio.testing@gmail.com> Co-authored-by: Chi Zhang <chizhg@google.com> Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com> Co-authored-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: Mitchel Herman <58443548+mpherman2@users.noreply.github.com> Co-authored-by: Dmitri Dolguikh <dmitri@appliedlogic.ca> Co-authored-by: Chao Dai <45011425+chaodaiG@users.noreply.github.com> Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pengyuan Bian <bianpengyuan@google.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Sam Naser <samnaser@google.com> Co-authored-by: Erick Fejta <fejta@google.com> Co-authored-by: jacob-delgado <jacob.delgado@volunteers.acasi.info> Co-authored-by: Steven Landow <steven@stlcomputerservices.com> Co-authored-by: Cole Wagner <colew@google.com> Co-authored-by: Xinnan Wen <richardwxn@gmail.com> Co-authored-by: Travis Clarke <9957358+clarketm@users.noreply.github.com> Co-authored-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a common-files update will cause 16 automated PRs to be generated. Some of the PRs end up in a race condition and need some help to finish. This is caused by a recent change as more automation was added to try and limit an exposure of not having the latest commits when building a release.
The 16 automated jobs:
If we can prevent some of the updates from happening, namely those in api, pkg, client-go, gogogen-proto and proxy caused by the common-files updates, we remove 7 of the automated PRs.
What is the drawback to not doing this? The istio repo will be pointing to older commits (but only ignoring commits with common files updates) of the 5 repos. The istio
update_deps.shscript will update to the latest commits. This means we are still seeing commits in istio from the 5 repos for non common-files changes, so still ahead of where we used to be (no automation in one repos). If we added a pre-submit job inrelease-builderto test for changes from an update_deps run, we could get back to making sure all repo references are up to date and limit the number of automated jobs using this PR.Thoughts?
Note that I am replacing the behavior with the --git-exclude parameter with new behavior as it was added recently and only used in a few cases.
Slack discussion: https://istio.slack.com/archives/C6FCV6WN4/p1625688978099700