Skip to content

Conversation

brian-avery
Copy link
Member

@brian-avery brian-avery requested a review from a team as a code owner September 22, 2020 14:46
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 22, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2020
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait on @howardjohn or others to verify how the specified configs are created.

@istio-testing istio-testing merged commit e9cf304 into istio:master Sep 22, 2020
@istio-testing
Copy link
Collaborator

@brian-avery: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key all-presets.yaml using file prow/cluster/jobs/all-presets.yaml

In response to this:

This mimics https://github.com/istio/test-infra/pull/2702/files for 1.6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants