Skip to content

Add release-1.3 branch protection #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

Add release-1.3 branch protection #1649

merged 1 commit into from
Aug 13, 2019

Conversation

howardjohn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 12, 2019
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn
To complete the pull request process, please assign fejta
You can assign the PR to them by writing /assign @fejta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2019
@howardjohn
Copy link
Member Author

/hold

I believe this will blow up until we actually have the release-1.3 branches created, is that correct @fejta @cjwagner ?

We plan to create them tomorrow

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Aug 12, 2019
@howardjohn howardjohn mentioned this pull request Aug 12, 2019
Closed
58 tasks
PiotrSikora
PiotrSikora reviewed Aug 12, 2019
View reviewed changes
prow/config/config_test.go
@@ -115,6 +115,15 @@ func TestConfig(t *testing.T) {
"merges-blocked-needs-admin",
},
},
{
name: "istio 1.3 requires admin merges",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 2 spaces.

@howardjohn howardjohn removed the do-not-merge/hold Block automatic merging of a PR. label Aug 13, 2019
@geeknoid geeknoid requested review from fejta and removed request for cjwagner August 13, 2019 19:07
@istio-testing istio-testing merged commit 4c347cc into istio:master Aug 13, 2019
@istio-testing
Copy link
Collaborator

@howardjohn: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn howardjohn mentioned this pull request Oct 14, 2019
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdake sdake Awaiting requested review from sdake

3 more reviewers

@PiotrSikora PiotrSikora PiotrSikora left review comments

@fejta fejta fejta approved these changes

@geeknoid geeknoid geeknoid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@howardjohn @istio-testing @PiotrSikora @fejta @geeknoid @googlebot