Link improvements #980
Merged
Link improvements #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When you hover over an HTML header, we now pop up a link icon holding a link to the header. Useful to support deep linking to a header. - When you click on a link that points outside of istio.io, the target is now opened in a separate tab. - Improved the coloring of links in the light theme so they're more visible. I was almost not able to see the difference between normal text and links, now the color delta is greater. Additionally, when you hover on a link, we now draw an underline. - Change the color of H1 headers to be black instead of being the same color as links. They're not links, they shouldn't be that color.
ldemailly
approved these changes
Feb 13, 2018
|
Looks good! I love the istio blue on the link :). thank you Martin so much!! |
linsun
approved these changes
Feb 13, 2018
|
merging, as color comment may be addressed later if Martin wants to. :) |
|
We can tweak the link color, but the previous color wasn't providing enough
contrast between the link color and normal text color. I often couldn't
tell what was a link and what wasn't without hovering the mouse over it. I
tried toning the color down a bit last night, but then it once again became
hard to tell the difference between links and normal text.
…On Tue, Feb 13, 2018 at 10:31 AM, Lin Sun ***@***.***> wrote:
merging, as color comment may be addressed later if Martin wants to. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#980 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVucHeYgwH12V1LetYj9Fvmw6gzDQF9_ks5tUdUEgaJpZM4SDRTL>
.
|
|
having non link being black is a good idea. but having links be electric blue isn't: #985 |
|
maybe you want to add a high contrast theme, but leave the default to the standard istio colors ? |
geeknoid
added a commit
that referenced
this pull request
Feb 15, 2018
* update docs for the fact the webhook files are not included in 0.5.1 (#983) * Update AWS automatic sidecar-injection (#958) * 0.5.1 (#982) * Link improvements (#980) - When you hover over an HTML header, we now pop up a link icon holding a link to the header. Useful to support deep linking to a header. - When you click on a link that points outside of istio.io, the target is now opened in a separate tab. - Improved the coloring of links in the light theme so they're more visible. I was almost not able to see the difference between normal text and links, now the color delta is greater. Additionally, when you hover on a link, we now draw an underline. - Change the color of H1 headers to be black instead of being the same color as links. They're not links, they shouldn't be that color. * Add missing webhook script files question to help page (#986) * Prepare for archiving.
charili
pushed a commit
to charili/istio.io
that referenced
this pull request
Nov 10, 2019
* update docs for the fact the webhook files are not included in 0.5.1 (istio#983) * Update AWS automatic sidecar-injection (istio#958) * 0.5.1 (istio#982) * Link improvements (istio#980) - When you hover over an HTML header, we now pop up a link icon holding a link to the header. Useful to support deep linking to a header. - When you click on a link that points outside of istio.io, the target is now opened in a separate tab. - Improved the coloring of links in the light theme so they're more visible. I was almost not able to see the difference between normal text and links, now the color delta is greater. Additionally, when you hover on a link, we now draw an underline. - Change the color of H1 headers to be black instead of being the same color as links. They're not links, they shouldn't be that color. * Add missing webhook script files question to help page (istio#986) * Prepare for archiving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you hover over an HTML header, we now pop up a link icon holding a link to the
header. Useful to support deep linking to a header.
When you click on a link that points outside of istio.io, the target is now
opened in a separate tab.
Improved the coloring of links in the light theme so they're more visible. I was almost not able to
see the difference between normal text and links, now the color delta is greater. Additionally, when you hover on a link, we now draw an underline.
Change the color of H1 headers to be black instead of being the same color
as links. They're not links, they shouldn't be that color.
Fixes #977 and #955
Staging: https://geeknoid.github.io/istio.github.io/