Skip to content

Remove flexvolume driver, clean up node_agent_k8s dir #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2018
Merged

Remove flexvolume driver, clean up node_agent_k8s dir #6305

merged 3 commits into from
Jun 18, 2018

Conversation

wattli
Copy link
Contributor

@wattli wattli commented Jun 14, 2018

No description provided.

@wattli wattli requested a review from incfly June 14, 2018 21:11
@wattli
Copy link
Contributor Author

wattli commented Jun 14, 2018

@incfly we should merge master to our branch some time.

@incfly incfly mentioned this pull request Jun 14, 2018
Merged
@incfly
Copy link

incfly commented Jun 14, 2018

mesh expansion node agent build fails

bin/gobuild.sh /go/out/linux_amd64/release/node_agent istio.io/istio/pkg/version ./security/cmd/node_agent
security/cmd/node_agent/na/config.go:21:2: cannot find package "istio.io/istio/security/cmd/node_agent_k8s/workload/handler" in any of:
	/go/src/istio.io/istio/vendor/istio.io/istio/security/cmd/node_agent_k8s/workload/handler (vendor tree)
	/usr/local/go/src/istio.io/istio/security/cmd/node_agent_k8s/workload/handler (from $GOROOT)
	/go/src/istio.io/istio/security/cmd/node_agent_k8s/workload/handler (from $GOPATH)

@wattli
Copy link
Contributor Author

wattli commented Jun 14, 2018

Fixed

@wattli wattli requested a review from quanjielin June 18, 2018 16:53
@quanjielin
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #6305 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6305    +/-   ##
=======================================
+ Coverage      67%     68%    +1%     
=======================================
  Files         349     341     -8     
  Lines       30687   30379   -308     
=======================================
- Hits        20534   20400   -134     
+ Misses       9302    9167   -135     
+ Partials      851     812    -39
Impacted Files Coverage Δ
security/cmd/node_agent/na/config.go 100% <ø> (ø) ⬆️
istioctl/cmd/istioctl/authn.go 50% <0%> (-23%) ⬇️
istioctl/cmd/istioctl/inject.go 27% <0%> (-16%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/prometheus/server.go 97% <0%> (-3%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 83% <0%> (-3%) ⬇️
pilot/pkg/networking/plugin/authz/rbac.go 79% <0%> (-1%) ⬇️
istioctl/cmd/istioctl/config.go 2% <0%> (-1%) ⬇️
mixer/pkg/protobuf/yaml/resolver.go 59% <0%> (-1%) ⬇️
mixer/adapter/stackdriver/trace/trace.go 88% <0%> (ø) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b84873...84910ef. Read the comment docs.

@quanjielin
Copy link
Contributor

/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: quanjielin, wattli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wattli
Copy link
Contributor Author

wattli commented Jun 18, 2018

/test istio-pilot-e2e
/test e2e-bookInfo

@wattli
Copy link
Contributor Author

wattli commented Jun 18, 2018

/test istio-pilot-e2e

@istio-testing istio-testing merged commit 84e3ddf into istio:master Jun 18, 2018
@istio-testing
Copy link
Collaborator

istio-testing commented Jun 18, 2018 •
edited
Loading

@wattli: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 84910ef link /test istio-pilot-e2e
prow/e2e-bookInfoTests.sh 84910ef link /test e2e-bookInfo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli wattli mentioned this pull request Jun 18, 2018
Closed
wattli added a commit to wattli/istio that referenced this pull request Jun 18, 2018
@wattli
Cherry pick istio#6305 with conflict resolved
dd37972
wattli added a commit that referenced this pull request Jun 19, 2018
@wattli
Cherry pick #6305 with conflict resolved (#6381)
e8059cc
quanjielin pushed a commit to quanjielin/istio that referenced this pull request Aug 16, 2018
@wattli @quanjielin
Remove flexvolume driver, clean up node_agent_k8s dir (istio#6305)
9c690f6 
* Remove flexvolume driver, clean up node_agent_k8s dir

* Fix lint
@quanjielin quanjielin mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incfly incfly Awaiting requested review from incfly

1 more reviewer

@quanjielin quanjielin quanjielin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@quanjielin quanjielin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wattli @incfly @quanjielin @istio-testing @googlebot