Skip to content

Conversation

chxchx
Copy link
Contributor

@chxchx chxchx commented Aug 2, 2017

Fixed the typo hub->tag

Release note:

NONE

@chxchx
Copy link
Contributor Author

chxchx commented Aug 2, 2017

/assign @sebastienvas

@sebastienvas
Copy link
Contributor

/approve no-issue

@sebastienvas
Copy link
Contributor

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chxchx, sebastienvas
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@chxchx
Copy link
Contributor Author

chxchx commented Aug 3, 2017

/assign @ldemailly

@ldemailly
Copy link
Member

ldemailly commented Aug 3, 2017

nit: in general a short description is nice to have
ie... "fixed typo hub->tag" or some such

@chxchx
Copy link
Contributor Author

chxchx commented Aug 3, 2017

Definitely

@istio-merge-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @chxchx @sebastienvas

@ldemailly ldemailly merged commit 8d1806a into istio:master Aug 4, 2017
rshriram pushed a commit that referenced this pull request Oct 30, 2017
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* jasons attempt

* Add short refresh delay

* buildifier

* add annoying shell var

* review comments
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Fix HTTPAPISpec doc.

* Regenerate protos
luksa pushed a commit to luksa/istio that referenced this pull request Sep 20, 2022
* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention
luksa pushed a commit to luksa/istio that referenced this pull request Sep 29, 2022
…tio#606)

* OSSM-742 Improve Maistra container images build (istio#534)

* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention

* Update MAISTRA_VERSION and ISTIO_VERSION

* Adapt images builds relying on upstream build tool

* Add copyright and license into scripts
luksa pushed a commit to luksa/istio that referenced this pull request Apr 11, 2024
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (istio#606)

* OSSM-742 Improve Maistra container images build (istio#534)

* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention

* Update MAISTRA_VERSION and ISTIO_VERSION

* Adapt images builds relying on upstream build tool

* Add copyright and license into scripts

* chore: updates image labels to reflect actual targeted versions

* chore: removes vendor left-overs

Co-authored-by: bmangoen <bmangoen@gmail.com>
dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (istio#606)

* OSSM-742 Improve Maistra container images build (istio#534)

* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention

* Update MAISTRA_VERSION and ISTIO_VERSION

* Adapt images builds relying on upstream build tool

* Add copyright and license into scripts

* chore: updates image labels to reflect actual targeted versions

* chore: removes vendor left-overs

Co-authored-by: bmangoen <bmangoen@gmail.com>
vikaschoudhary16 pushed a commit to vikaschoudhary16/istio that referenced this pull request Aug 12, 2024
Merge `Istio 1.21.4` patch to `tcc-1.21`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants