Skip to content

fix consul and eureka bookinfo sidecars #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2018
Merged

fix consul and eureka bookinfo sidecars #4181

merged 1 commit into from
Mar 11, 2018

Conversation

rkpagadala
Copy link
Contributor

No description provided.

@rkpagadala rkpagadala requested review from a team and ldemailly March 11, 2018 06:59
@rkpagadala rkpagadala mentioned this pull request Mar 11, 2018
Merged
@codecov
Copy link

codecov bot commented Mar 11, 2018 •
edited
Loading

Codecov Report

Merging #4181 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4181    +/-   ##
=======================================
- Coverage      73%     73%   -<1%     
=======================================
  Files         313     313            
  Lines       28898   28894     -4     
=======================================
- Hits        21028   21016    -12     
- Misses       6543    6554    +11     
+ Partials     1327    1324     -3
Impacted Files Coverage Δ
mixer/adapter/solarwinds/log_handler.go 34% <0%> (-24%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-3%) ⬇️
pilot/pkg/config/kube/crd/controller.go 77% <0%> (-1%) ⬇️
mixer/adapter/opa/opa.go 78% <0%> (ø) ⬇️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
mixer/adapter/list/stringList.go 100% <0%> (ø) ⬆️
mixer/adapter/list/ipList.go 100% <0%> (ø) ⬆️
mixer/adapter/circonus/circonus.go 72% <0%> (+1%) ⬆️
mixer/adapter/rbac/controller.go 55% <0%> (+3%) ⬆️
mixer/adapter/noop/noop.go 84% <0%> (+5%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3988402...07de273. Read the comment docs.

ldemailly
ldemailly approved these changes Mar 11, 2018
View reviewed changes
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@ldemailly
Copy link
Member

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-testing
Copy link
Collaborator

istio-testing commented Mar 11, 2018 •
edited
Loading

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 07de273 link /test istio-unit-tests
prow/istio-pilot-e2e.sh 07de273 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala rkpagadala merged commit f8cd83a into istio:master Mar 11, 2018
@mattdelco
Copy link
Contributor

Other instances to consider:

install/kubernetes/templates/istio-sidecar-injector-configmap-release.yaml.tmpl:        image: {PILOT_HUB}/proxy_init:{PILOT_TAG}
install/kubernetes/templates/istio-sidecar-injector-configmap-release.yaml.tmpl:        image: {PILOT_HUB}/proxy:{PILOT_TAG}

install/kubernetes/templates/istio-sidecar-injector-configmap-debug.yaml.tmpl:        image: {PILOT_HUB}/proxy_init:{PILOT_TAG}
install/kubernetes/templates/istio-sidecar-injector-configmap-debug.yaml.tmpl:        image: {PILOT_HUB}/proxy_debug:{PILOT_TAG}

samples/bookinfo/eureka/templates/bookinfo.sidecars.yaml.tmpl:    image: {PILOT_HUB}/proxy_init:{PILOT_TAG}

I'm assuming proxy and proxy_debug should be using the same hub/tag variable though I'm not sure if proxy_init should also be using that or if pilot's hub/tag is okay. There's several instances in the last file I quoted.

@rkpagadala rkpagadala mentioned this pull request Mar 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ldemailly ldemailly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkpagadala @ldemailly @istio-merge-robot @istio-testing @mattdelco @googlebot