Remove previously deprecated mixerclient.v1 config #3616
Conversation
mandarjog
commented
Feb 20, 2018
- Removes previously deprecated mixerclient.v1 config. Now only v2 is available.
- Do not supply "default" attributes on the outbound route. There is no reasonable default.
|
so much green / passing builds, it's fishy ;-) /lgtm |
| @@ -964,7 +964,7 @@ func buildEgressVirtualHost(serviceName string, destination string, | |||
| port.Protocol = protocolToHandle | |||
|
|
|||
| if mesh.MixerCheckServer != "" || mesh.MixerReportServer != "" { | |||
| oc := buildMixerConfig(node, serviceName, dest, config, mesh.DisablePolicyChecks, false) | |||
| oc := buildMixerConfig(node, serviceName, dest, proxyInstances, config, mesh.DisablePolicyChecks, false) | |||
There was a problem hiding this comment.
are those unrelated changes ?
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test istio-presubmit |
|
/lgtm |
|
@mandarjog: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly, mandarjog, qiwzhang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test istio-presubmit |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |