Backport changes to new installer #14210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only field it references is one that is not configurable anyways, so we can hard code it in the template safely. If it does need to be configured in the future, we should read from values directly rather than MeshConfig. Backport of c3e66b2 from istio/installer
backport of istio#138 from istio/installer
backport of istio/install istio#165
Backport of istio/install istio#166
backport of istio/install istio#152
backport of istio/installer istio#170
49d75e9 to
fa35e18
Compare
|
/test integ-pilot-k8s-presubmit-tests-master |
1 similar comment
|
/test integ-pilot-k8s-presubmit-tests-master |
fpesce
reviewed
May 21, 2019
costinm
approved these changes
May 21, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: costinm, howardjohn, mandarjog, morvencao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we will be shipping 1.2 with the old installer and the new installer (as alpha/beta) we need to backport some of the changes that were made.
Changes included:
istio/installer/pull/78
istio/installer/pull/138
istio/installer/pull/165
istio/installer/pull/166
istio/installer/pull/152
istio/installer/pull/170