This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Remove Injector dependency on MeshConfig #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only field it references is one that is not configurable anyways, so we can hard code it in the template safely. If it does need to be configured in the future, we should read from values directly rather than MeshConfig. Signed-off-by: John Howard <howardjohn@google.com>
5c72b01 to
c3e66b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only field it references is one that is not configurable anyways, so
we can hard code it in the template safely. If it does need to be
configured in the future, we should read from values directly rather
than MeshConfig.
Part of https://github.com/istio-ecosystem/istio-installer/issues/75