Skip to content

Fix Wasm VM shutdown. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2020
Merged

Fix Wasm VM shutdown. #159

merged 2 commits into from
Feb 24, 2020

Conversation

PiotrSikora
Copy link

@PiotrSikora PiotrSikora force-pushed the wasm-safe_shutdown-1.5 branch from e986cd5 to 17b4669 Compare February 22, 2020 18:39
@PiotrSikora
Copy link
Author

/retest

@PiotrSikora PiotrSikora force-pushed the wasm-safe_shutdown-1.5 branch 2 times, most recently from bffa8e2 to e8c577c Compare February 23, 2020 00:51
@PiotrSikora
Copy link
Author

/retest

@PiotrSikora PiotrSikora force-pushed the wasm-safe_shutdown-1.5 branch 2 times, most recently from 94340eb to 0709cd7 Compare February 24, 2020 01:53
@jplevyak @PiotrSikora
Move proxy_on_delete() call out of proxy_done() call from the VM (make (
020e5e2 
envoyproxy#405)

non-reentrant).

Signed-off-by: John Plevyak <jplevyak@gmail.com>
@jplevyak @PiotrSikora
Simplify Wasm shutdown. (envoyproxy#410)
e2718f4 
Signed-off-by: John Plevyak <jplevyak@gmail.com>
@PiotrSikora PiotrSikora force-pushed the wasm-safe_shutdown-1.5 branch from 0709cd7 to e2718f4 Compare February 24, 2020 02:14
@istio-testing
Copy link

@PiotrSikora: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-tsan_envoy_release-1.5 e2718f4 link /test test-tsan_envoy_release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bianpengyuan
bianpengyuan approved these changes Feb 24, 2020
View reviewed changes
Copy link

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like test timeouts. I think it is reasonable to ignore them for now.

@bianpengyuan bianpengyuan merged commit f10e36f into istio:release-1.5 Feb 24, 2020
Miss-you pushed a commit to Miss-you/envoy that referenced this pull request Nov 17, 2020
@majinghe
Merge pull request istio#159 from scilla0531/zh_trans_security
14f6771 
zh-translation: docs/root/intro/arch_overview/security/security.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov Awaiting requested review from kyessenov

1 more reviewer

@bianpengyuan bianpengyuan bianpengyuan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PiotrSikora @istio-testing @bianpengyuan @googlebot @jplevyak