cross-repo e2e gating for the operator #379

sdake · 2019-10-14T19:48:39Z

This work runs e2e testing using end to end testing against the
istio/istio repository.

To run - use make e2e.

howardjohn · 2019-10-16T21:39:58Z

tests/e2e/e2e.sh

+
+function cleanup_kind_cluster() {
+    kind export logs --name istio-testing "${ARTIFACTS}/kind"
+#    kind delete cluster --name=istio-testing


This is a must have! see kubernetes-sigs/kind#759. We should have a consolidated kind library. Maybe in common files? Opened istio/istio#17948 to track this

I agree a consolidated setup library would be great. When I come up for air after 1.4, I had planned to work a bit more on cross-repo gating and make things generic enough so that different components can use the same set of scripts...

comment removed from line 23.

howardjohn · 2019-10-16T21:40:50Z

tests/e2e/e2e.sh

+    - name: default
+      protocol: layer2
+      addresses:
+      - 172.17.255.1-172.17.255.250


will this work in all environments? An alternative used in installer is a nodeport

I am not sure. It works where we need it the most - which is automated testing. This (should) work on all Linux platforms. I have read in the past this may not work well on mac, but I have no reason to think it may not. I'd suggest a little latitude here, so I can prove this out, and if things are not working, I can setup the call to --use-local or whatever it is for e2e. We have a project goal of getting rid of nodeport testing...

howardjohn · 2019-10-16T21:41:18Z

tests/e2e/e2e.sh

+}
+
+function setup_docker() {
+#  HUB=istio-testing TAG=istio-testing make -f Makefile.core.mk docker


don't we need to build?

done. Not sure why things worked well for me prior.

howardjohn · 2019-10-16T21:42:00Z

tests/e2e/e2e.sh

+
+if [[ ! -d "${ISTIO_DIR}" ]]
+then
+  git clone https://github.com/istio/istio.git "${ISTIO_DIR}"


shouldn't this be done before we write the istio-operator.yaml?

This work runs e2e testing using end to end testing against the istio/istio repository. To run - use `make e2e`. Depends-On: istio/istio#17864

sdake · 2019-10-17T01:11:19Z

@howardjohn PTAL thanks!

howardjohn

looks good except that one comment

howardjohn · 2019-10-17T01:18:01Z

go.mod

@@ -69,6 +69,7 @@ require (
 	k8s.io/kube-proxy v0.0.0-00010101000000-000000000000 // indirect
 	k8s.io/kubectl v0.0.0-20191003004222-1f3c0cd90ca9
 	sigs.k8s.io/controller-runtime v0.2.2
+	sigs.k8s.io/kind v0.5.1 // indirect


this should not be here and pulls in dependencies that may not be ok for istio/istio

Ya not sure why this is present will fix this after dinner tonight.

morvencao

@sdake Can we addd license CC-BY-4.0 to https://github.com/istio/operator/blob/master/common/config/license-lint.yml to pass the license linter?

istio-testing · 2019-10-17T04:22:54Z

@sdake: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
gencheck_operator	`e0bd815`	link	`/test gencheck_operator`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sdake · 2019-10-17T04:27:24Z

@sdake Can we addd license CC-BY-4.0 to https://github.com/istio/operator/blob/master/common/config/license-lint.yml to pass the license linter?

I reverted the gomod changes so the liniter should be gtg now.

linsun · 2019-10-17T13:08:50Z

tests/e2e/e2e.sh

+# Create a clone of the Istio repository
+if [[ ! -d "${ISTIO_DIR}" ]]
+then
+  git clone https://github.com/sdake/istio.git "${ISTIO_DIR}"


is this correct? pointing to your personal repo?

also, not sure why this cmd is needed? Seems you need to clone the istio-operator repo to get the deploy dir.

please follow up on this

howardjohn · 2019-10-17T15:21:35Z

tests/e2e/e2e.sh

+# Create a clone of the Istio repository
+if [[ ! -d "${ISTIO_DIR}" ]]
+then
+  git clone https://github.com/sdake/istio.git "${ISTIO_DIR}"


please follow up on this

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake requested a review from a team as a code owner October 14, 2019 19:48

googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 14, 2019

istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2019

sdake pushed a commit to sdake/test-infra that referenced this pull request Oct 14, 2019

Implement operator e2e

2e5302b

Depends-On: istio/operator#379

This was referenced Oct 14, 2019

Implement operator e2e istio/test-infra#1933

Merged

Add operator support to e2e tests istio/istio#17864

Merged

howardjohn reviewed Oct 16, 2019

View reviewed changes

ostromart mentioned this pull request Oct 17, 2019

In cluster controller e2e tests istio/istio#17220

Closed

Steven Dake added 2 commits October 16, 2019 18:05

cross-repo e2e gating for the operator

9ee515d

This work runs e2e testing using end to end testing against the istio/istio repository. To run - use `make e2e`. Depends-On: istio/istio#17864

Address reviewer comments.

8241a06

sdake force-pushed the operator_e2e branch from f2fed73 to 8241a06 Compare October 17, 2019 01:10

howardjohn reviewed Oct 17, 2019

View reviewed changes

morvencao self-requested a review October 17, 2019 03:22

morvencao reviewed Oct 17, 2019

View reviewed changes

Revert all gomod changes

e0bd815

linsun reviewed Oct 17, 2019

View reviewed changes

howardjohn approved these changes Oct 17, 2019

View reviewed changes

istio-testing pushed a commit to istio/test-infra that referenced this pull request Oct 17, 2019

Implement operator e2e (#1933)

242a3d6

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

istio-testing merged commit 1057319 into istio:master Oct 17, 2019

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 1, 2019

Implement operator e2e (istio#1933)

b77244c

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 1, 2019

Implement operator e2e (istio#1933)

8b3b0cd

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 1, 2019

Implement operator e2e (istio#1933)

a7f8127

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 5, 2019

Implement operator e2e (istio#1933)

ad50fde

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 5, 2019

Implement operator e2e (istio#1933)

1f5c128

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 5, 2019

Implement operator e2e (istio#1933)

a5cff42

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 17, 2019

Implement operator e2e (istio#1933)

77f048b

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 18, 2019

Implement operator e2e (istio#1933)

3e735d7

* Implement operator e2e Depends-On: istio/operator#379 * Address reviewer comments

sdake mentioned this pull request Apr 29, 2020

istioctl: allow setting remote istiod port istio/istio#23357

Closed

cross-repo e2e gating for the operator #379

cross-repo e2e gating for the operator #379

Uh oh!

Conversation

sdake commented Oct 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdake Oct 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdake commented Oct 17, 2019

Uh oh!

howardjohn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

morvencao left a comment

Choose a reason for hiding this comment

Uh oh!

istio-testing commented Oct 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sdake commented Oct 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sdake Oct 17, 2019 •

edited

Loading

istio-testing commented Oct 17, 2019 •

edited

Loading