This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Use release-1.3 tag for release-1.3 branch #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlenglet
commented
Aug 20, 2019
58 tasks
|
Tests are passing. Please someone take a look. |
fb8bf33 to
4825c5c
Compare
|
@ostromart Please review again. |
|
And I'll need an approval from @istio/release-managers-1-3. Thanks! |
ostromart
approved these changes
Aug 21, 2019
sdake
approved these changes
Aug 21, 2019
| @@ -2,7 +2,7 @@ apiVersion: install.istio.io/v1alpha2 | |||
| kind: IstioControlPlane | |||
| spec: | |||
| hub: gcr.io/istio-release | |||
| tag: master-latest-daily | |||
| tag: release-1.3-latest-daily | |||
There was a problem hiding this comment.
need to ensure this tag is available at some point or the operator will be doa in the firs trc.
There was a problem hiding this comment.
Good point.
@howardjohn do you know what needs to be done to get those daily builds created?
4825c5c to
4d2796f
Compare
|
it's already done we have had daily builds since the day we cut the release
branch
…On Wed, Aug 21, 2019, 8:07 AM Istio Automation ***@***.***> wrote:
Merged #216 <#216> into release-1.3.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#216?email_source=notifications&email_token=AAEYGXLGKAEUMKC6JQV3LTTQFVK3ZA5CNFSM4INN4SRKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTFR3IAY#event-2573448195>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEYGXP443C5PZAWQG3PTPLQFVK3ZANCNFSM4INN4SRA>
.
|
Yeah, that's what I thought too, but I can't find them on https://gcr.io/istio-release |
|
https://gcsweb.istio.io/gcs/istio-prerelease/daily-build/release-1.3-latest-daily/
`docker run gcr.io/istio-release/pilot:release-1.3-latest-daily` works for
me
…On Wed, Aug 21, 2019 at 8:26 AM Romain Lenglet ***@***.***> wrote:
it's already done we have had daily builds since the day we cut the release
branch
Yeah, that's what I thought too, but I can't find them on
https://gcr.io/istio-release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#216?email_source=notifications&email_token=AAEYGXJSMR67RFSVURGAQNDQFVNEFA5CNFSM4INN4SRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD42BWDI#issuecomment-523508493>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEYGXMYE2LIUA76ZSZ4ENLQFVNEFANCNFSM4INN4SRA>
.
|
|
Right. I was looking for an operator image... |
|
I don't think there is an operator image? It is just a part of istioctl |
|
Got it. I was confused. Thanks! |
|
Right, there's no operator image atm, it's only in the CLI. |
This was referenced Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.