Skip to content

PointPillars Waymo distributed training model weights and docs. #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2023
Merged

PointPillars Waymo distributed training model weights and docs. #585

merged 5 commits into from
Feb 27, 2023

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Feb 22, 2023 •
edited
Loading

  • Training speedup with GPUs.
  • Add model weight file + metrics.
  • Script for running training with SLURM.

image

This change is Reviewable

@ssheorey
Add slurm script
a5c1ba7 
get NODE_RANK from env
WIP docs
@ssheorey
Add model weight link
2552a6e 
Update SLURM launch script.
@ssheorey
Add training time plot
1280e17
@ssheorey ssheorey marked this pull request as ready for review February 22, 2023 20:32
@ssheorey ssheorey requested a review from benjaminum February 22, 2023 20:32
benjaminum
benjaminum requested changes Feb 26, 2023
View reviewed changes
Copy link
Collaborator

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the .ply file used? Can it be put in a subdir?

Reviewed 21 of 22 files at r1.
Reviewable status: 21 of 22 files reviewed, all discussions resolved

ssheorey
ssheorey commented Feb 27, 2023
View reviewed changes
Copy link
Member Author

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Removed.

Reviewable status: 21 of 22 files reviewed, all discussions resolved (waiting on @benjaminum)

benjaminum
benjaminum approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 21 of 22 files reviewed, all discussions resolved

@ssheorey ssheorey merged commit 01776f7 into dev Feb 27, 2023
@ssheorey ssheorey deleted the ss/distrib-doc branch February 27, 2023 16:30
@ssheorey ssheorey restored the ss/distrib-doc branch February 27, 2023 17:59
@ssheorey ssheorey deleted the ss/distrib-doc branch February 27, 2023 17:59
ssheorey added a commit that referenced this pull request Feb 27, 2023
@ssheorey
PointPillars Waymo distributed training model weights and docs (PR #585
66131df 
)

- Training speedup with GPUs.
- Add model weight file + metrics.
- Script for running training with SLURM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminum benjaminum benjaminum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssheorey @benjaminum