Skip to content

Conversation

nachanon
Copy link
Contributor

@nachanon nachanon commented Sep 8, 2020

Current Irssi's stock colorless theme does not contain any code to de-color vertical window split bars (i.e. bug #1220), resulting in them being colored with default blue background; defeating the purpose of the theme.

This one-line change introduces following line into themes/colorless.theme:

  window_border = "%8";

Which makes the vertical window split bars use reverse-video of default terminal foreground/background instead.

Screenshots

Before the fix:
(Screenshot)

After the fix:
(Screenshot)

Caveat

This fix brings out a quirk in Irssi's styling implementation— where vertical window split bar's styling overlapped with the bottom status bar's styling, resulting in a black cell at the middle of bottom status bar. (Status bar used reverse video, and split bar reversed it back)

Fixing the quirk itself might entail redefining the extent of of window split bar and/or status bar drawing inside Irssi's main codebase (with consideration on effects on other themes' compatibility); but that warrants a dedicated ticket for another day.

Having this fix is likely to be better than leaving color in colorless theme of course.

System Information

Irssi: 1.2.2 (20190829 0225)*
System: Fedora 32 (GNU/Linux x86_64)

* The change is tested by installing the new theme file as a user's own theme file.

@ailin-nemui ailin-nemui added the auto-merge This PR is scheduled for merge if no further comments are opened label Sep 8, 2020
@ailin-nemui
Copy link
Contributor

@irssi/developers

@ailin-nemui ailin-nemui merged commit 561619f into irssi:master Sep 11, 2020
ailin-nemui added a commit that referenced this pull request Apr 8, 2021
Decolor the vertical window split bar in stock `colorless` theme

(cherry picked from commit 561619f)
@ailin-nemui ailin-nemui added this to the 1.2.3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge This PR is scheduled for merge if no further comments are opened z-affects-1.2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants