Skip to content

fix missing wrapping of line in signals #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2020
Merged

fix missing wrapping of line in signals #1209

merged 2 commits into from
Jul 26, 2020

Conversation

ailin-nemui
Copy link
Contributor

related to #1079 / 57fb173

the signals that include LINE_REC*s do not have any possibility to wrap these, so we have to create some more code

otherwise we get a segv in perl_line_fill_hash, which is passed a raw LINE_REC* when called from plain_bless
in perl-signals.c

@ailin-nemui ailin-nemui force-pushed the perl_line_signal_arg branch from d34bf76 to 962f228 Compare July 22, 2020 22:53
@ailin-nemui ailin-nemui force-pushed the perl_line_signal_arg branch from 962f228 to ffe0c71 Compare July 23, 2020 09:54
@ailin-nemui ailin-nemui added the auto-merge This PR is scheduled for merge if no further comments are opened label Jul 23, 2020
@ailin-nemui
Copy link
Contributor Author

@irssi/developers

@ailin-nemui ailin-nemui merged commit f8052b7 into irssi:master Jul 26, 2020
@ailin-nemui ailin-nemui deleted the perl_line_signal_arg branch March 3, 2021 08:26
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge This PR is scheduled for merge if no further comments are opened
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ailin-nemui