Skip to content

Conversation

thomaskf
Copy link
Collaborator

Few bug fixes:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if this this the right way, when you changed from:
out << saln->partitions[part]->sequence_type << ", ";
to
out << saln->partitions[part]->sequence_type;
why is printing comma removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bqminh ,

I just modified the code so that the comma will be printed out only when both sequence_type and pos are not empty.

if (!saln->partitions[part]->sequence_type.empty() && !pos.empty()) {
       out << ", ";
}

For the "charset" line, a comma will be outputted when both sequence type and position are not empty.
Copy link
Member

@bqminh bqminh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, thx

@bqminh bqminh merged commit cbf4aad into master Jul 30, 2024
5 of 6 checks passed
thomaskf pushed a commit to thomaskf/iqtree2 that referenced this pull request Feb 27, 2025
thomaskf pushed a commit to thomaskf/iqtree2 that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in writing best_model.nex file Error when estimating linked exchangeabilities (GTRpmix)
2 participants