-
-
Notifications
You must be signed in to change notification settings - Fork 68
Version 2.3.6 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.3.6 #284
Conversation
…nked exchangeabilities
… of protein + FO model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this this the right way, when you changed from:
out << saln->partitions[part]->sequence_type << ", ";
to
out << saln->partitions[part]->sequence_type;
why is printing comma removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bqminh ,
I just modified the code so that the comma will be printed out only when both sequence_type and pos are not empty.
if (!saln->partitions[part]->sequence_type.empty() && !pos.empty()) {
out << ", ";
}
For the "charset" line, a comma will be outputted when both sequence type and position are not empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, thx
Version 2.3.6
Version 2.3.6
Few bug fixes: