feat: require go1.25 for building kubo #10913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48b1408 to
e254926
Compare
This reverts commit cb56425.
lidel
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
@gammazero thanks! CI is green, let's include this in 0.37.0-rc1.
FYI
- I've reverted cb56425 because it caused this bug to come back: https://github.com/ipfs/kubo/actions/runs/16952202746/job/48047163245?pr=10913#step:5:8
- Rebased on latest master to include fix from #10914
If these changes look ok to you, feel free to suash&merge 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://go.dev/doc/go1.25