fix(ci): docker build #10914
Merged
fix(ci): docker build #10914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker builds were failing because go list commands in mk/golang.mk didn't inherit GOFLAGS from the environment, causing empty package names when .git directory was incomplete. This issue always existed but was masked until recent changes in GitHub Actions runners or Docker golang image exposed it.
Fixes Docker build deprecation warnings.
|
Green, merging so we can rebase PRs and fix CI. |
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker started failing in master and PRs – see #10905 (comment)
Looked into this and I am more confused than I was before.
GOFLAGS=-buildvcs=falseIS in theDockerfile. The problem is that theMakefile's$(shell ...)commands don't inherit this environment variable.This isn't a regression from a Go 1.25 update, image/ci uses 1.24. I suspect the issue has likely always existed but may have been masked or only recently become apparent due to (guessing):
The root cause is that
$(shell ...)in Make creates a new shell that doesn't inherit the parent's environment variables unless explicitly passed. My fix addresses this by hardcoding-buildvcs=falsefor thego listcommands that are used to determine package names.While at it, updated ENV to use modern notation.
cc @ipfs/kubo-maintainers for visibility.