Skip to content

chore: Upgrade github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 support #10850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 25, 2025

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6
@stefanb stefanb changed the title Upgrade github.com/cockroachdb/swiss for Go 1.25 support fix: github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 Jun 26, 2025
@stefanb stefanb changed the title fix: github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 chore: github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 Jun 26, 2025
@stefanb stefanb changed the title chore: github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 chore: github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 support Jun 26, 2025
@stefanb stefanb changed the title chore: github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 support chore: Upgrade github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 support Jun 29, 2025
@hsanjuan
Copy link
Contributor

I think this one would be bubbled by updating go-ds-pebble

@stefanb
Copy link
Contributor Author

stefanb commented Jul 1, 2025

@hsanjuan yes, once github.com/cockroachdb/pebble/v2 is updated to 2.0.6 or later in github.com/ipfs/go-ds-pebble and included in a release: https://github.com/ipfs/go-ds-pebble/releases

@gammazero
Copy link
Contributor

gammazero commented Jul 2, 2025

Added support for pebble v2.0.6 via go-ds-pebble v0.5.1

Updated this PR to depend on go-ds-pebble v0.5.1

@gammazero gammazero merged commit 6f0c1de into ipfs:master Jul 2, 2025
17 checks passed
@stefanb
Copy link
Contributor Author

stefanb commented Jul 2, 2025

Thanks, @gammazero!
Please don't forget to make a release before or right after go 1.25 is released in August (rc2 is expected on tuesday, July 8th).

@stefanb stefanb deleted the go-1.25 branch July 2, 2025 05:23
lidel pushed a commit that referenced this pull request Jul 8, 2025
… support (#10850)

* Upgrade github.com/cockroachdb/swiss for Go 1.25 support

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6

* Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support

---------

Co-authored-by: gammazero <11790789+gammazero@users.noreply.github.com>
(cherry picked from commit 6f0c1de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants