Skip to content

fix: allow daemon to start correctly if the API is null #10062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: allow daemon to start correctly if the API is null #10062

merged 2 commits into from
Dec 11, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 11, 2023

Fixes: #10056

@Jorropo Jorropo added the skip/changelog This change does NOT require a changelog entry label Aug 11, 2023
@Jorropo Jorropo requested a review from a team as a code owner August 11, 2023 01:34
@Jorropo Jorropo force-pushed the fix/10056 branch 2 times, most recently from a986fe2 to 100ccfd Compare August 15, 2023 13:07
@Jorropo Jorropo enabled auto-merge (rebase) August 15, 2023 13:11
hacdias
hacdias reviewed Aug 17, 2023
View reviewed changes
hacdias
hacdias requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix test.

@hacdias
Copy link
Member

hacdias commented Nov 20, 2023

Ping @Jorropo

@hacdias hacdias force-pushed the fix/10056 branch 2 times, most recently from d37cf6c to 351d27f Compare December 11, 2023 10:30
@hacdias hacdias disabled auto-merge December 11, 2023 10:44
@hacdias hacdias merged commit 8c4bdd8 into master Dec 11, 2023
@hacdias hacdias deleted the fix/10056 branch December 11, 2023 10:45
@hacdias hacdias mentioned this pull request Dec 11, 2023
Closed
9 tasks
Jorropo added a commit that referenced this pull request Dec 14, 2023
@Jorropo
fix: allow daemon to start correctly if the API is null (#10062)
f93a386 
(cherry picked from commit 8c4bdd8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

Assignees

@Jorropo Jorropo

Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panics on startup
2 participants
@Jorropo @hacdias