Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ipfs/eslint-config-ipfs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.7
Choose a base ref
...
head repository: ipfs/eslint-config-ipfs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.0
Choose a head ref
  • 9 commits
  • 17 files changed
  • 4 contributors

Commits on Apr 5, 2023

  1. chore: use unified ci

    @achingbrain
    achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2674c56 View commit details
    Browse the repository at this point in the history

  2. chore: convert to aegir project

    @achingbrain
    achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    81d8ba3 View commit details
    Browse the repository at this point in the history

  3. feat!: add import sorting rule (#126) 

    Lint import sorting, and support auto-fixing of import order. see ipfs/aegir#1178 for an example

---------

Co-authored-by: Alex Potsides <alex@achingbrain.net>
    @SgtPooki @achingbrain
    SgtPooki and achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1462d09 View commit details
    Browse the repository at this point in the history

  4. chore(deps): bump eslint-plugin-jsdoc from 39.9.1 to 40.1.1 (#139) 

    Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 39.9.1 to 40.1.1.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](gajus/eslint-plugin-jsdoc@v39.9.1...v40.1.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot @achingbrain
    dependabot[bot] authored and achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bd1422b View commit details
    Browse the repository at this point in the history

  5. chore(deps): bump eslint-config-standard-with-typescript from 27.0.1 … 

    …to 34.0.1 (#135)

Bumps [eslint-config-standard-with-typescript](https://github.com/standard/eslint-config-standard-with-typescript) from 27.0.1 to 34.0.1.
- [Release notes](https://github.com/standard/eslint-config-standard-with-typescript/releases)
- [Changelog](https://github.com/standard/eslint-config-standard-with-typescript/blob/master/CHANGELOG.md)
- [Commits](mightyiam/eslint-config-love@v27.0.1...v34.0.1)

---
updated-dependencies:
- dependency-name: eslint-config-standard-with-typescript
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot @achingbrain
    dependabot[bot] authored and achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    fc9aa6f View commit details
    Browse the repository at this point in the history

  6. feat!: lint jsx (#140) 

    Add `*.jsx` and `*.tsx` to list of files that are linted.

BREAKING CHANGE: previously jsx and tsx files were not linted, now they are
    @achingbrain
    achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    fb5e5b6 View commit details
    Browse the repository at this point in the history

  7. fix!: only require awaiting promises returned from inside try/catch… 

    … blocks (#133)

Returning unawaited promises from inside try/catch blocks is usually
a bug as the author more than likely intends the catch part to handle
errors.

The configuration in this PR disallows `await` before `return` unless
it is inside a `try/catch` in which case it is required.

`await` before `return` doesn't cause any harm but I don't think we
can configure the rule any other way.

This is a breaking change but one that is fixable with `npm run lint -- --fix`

Fixes: #130

BREAKING CHANGE: `await` is not allowed before `return` unless it is inside a `try/catch` in which case it is required

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
    @achingbrain @SgtPooki
    achingbrain and SgtPooki committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a6e4a7b View commit details
    Browse the repository at this point in the history

  8. chore: fix linting

    @achingbrain
    achingbrain committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    adffc58 View commit details
    Browse the repository at this point in the history

  9. chore(release): 4.0.0 [skip ci] 

    ## [4.0.0](v3.1.7...v4.0.0) (2023-04-05)

### ⚠ BREAKING CHANGES

* `await` is not allowed before `return` unless it is inside a `try/catch` in which case it is required

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
* previously jsx and tsx files were not linted, now they are
* add import sorting rule (#126)

### Features

* add import sorting rule ([#126](#126)) ([1462d09](1462d09))
* lint jsx ([#140](#140)) ([fb5e5b6](fb5e5b6))

### Bug Fixes

* only require `await`ing promises returned from inside try/catch blocks ([#133](#133)) ([a6e4a7b](a6e4a7b)), closes [#130](#130)

### Trivial Changes

* convert to aegir project ([81d8ba3](81d8ba3))
* **deps:** bump eslint-config-standard-with-typescript from 27.0.1 to 34.0.1 ([#135](#135)) ([fc9aa6f](fc9aa6f))
* **deps:** bump eslint-plugin-jsdoc from 39.9.1 to 40.1.1 ([#139](#139)) ([bd1422b](bd1422b))
* fix linting ([adffc58](adffc58))
* use unified ci ([2674c56](2674c56))
    @semantic-release-bot
    semantic-release-bot committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9b091f7 View commit details
    Browse the repository at this point in the history
Loading