Skip to content

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Mar 16, 2021

This PR implements the USM MemAdvise function for CUDA backend.

The PI_COMMAND_TYPE_MEMADVISE enumerator is added, the value of which is derived from CL_COMMAND_MEMADVISE_INTEL constant as defined in the preview USM extension specification.

@nyalloc nyalloc requested review from smaslov-intel and a team as code owners March 16, 2021 13:31
@nyalloc nyalloc changed the title Implemented cuda_piextUSMEnqueueMemAdvise [SYCL][CUDA] Implemented cuda_piextUSMEnqueueMemAdvise Mar 22, 2021
@nyalloc
Copy link
Contributor Author

nyalloc commented Apr 6, 2021

Hello @smaslov-intel ! Hope you are well. This PR seems to have flown under the radar - can we do anything to move this along?

Cheers.

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment

@nyalloc
Copy link
Contributor Author

nyalloc commented Apr 12, 2021

Please address comment

No problem, happy to fix this. I'll update the PR today.

@nyalloc
Copy link
Contributor Author

nyalloc commented Apr 12, 2021

@smaslov-intel Updated. Thanks for the feedback.

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit 2b56ac9 into intel:sycl Apr 13, 2021
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 14, 2021
* upstream/sycl: (39 commits)
  [CI] Switch to default clang-format version. (intel#3540)
  [Driver][NFC] Cleanup some option setting for SYCL offload (intel#3542)
  [GitHub Actions] Update main branch sync schedule
  [SYCL][NFC] Fix potential namespace conflicts with PSTL in tuple.hpp (intel#3541)
  [SYCL] Bump sycl library minor version (intel#3538)
  [SYCL][CUDA] Implemented cuda_piextUSMEnqueueMemAdvise (intel#3365)
  [SYCL][FPGA] Add mutual diagnostic of max_concurrency attribute in conjunction of disable_loop_pipelining attribute (intel#3512)
  [SYCL] [MATRIX] Enable joint_matrix_load, joint_matrix_store, and joint_matrix_mad for AMX (intel#3503)
  [ESIMD] Skip rewriting functions used through function pointers (intel#3527)
  [SYCL] Fix address space for spec constants buffer (intel#3521)
  [SYCL] Correct the tablegen for checking mutually exclusive stmt attrs (intel#3519)
  [SYCL][PI][L0][NFC] Refactor setting of LastCommandEvent (intel#3528)
  [SYCL] Fix group local memory sharing issue (intel#3489)
  [SYCL][NFC] Fix post-commit failure (intel#3532)
  [SYCL][Doc] Remove extension mechanism (intel#3526)
  [SYCL] Move sycl.hpp in install directory and adjust driver to match (intel#3523)
  [SYCL][ESIMD] Update ESIMD docs to address recent user comments: (intel#3516)
  [NFCI][SYCL] Correct -fdeclare-spirv-builtins to use marshalling (intel#3515)
  [SYCL] Rework MarkDevice and children (intel#3475)
  [SYCL] Fix StringLiteral Ctor issue from intel#3504. (intel#3520)
  ...
@bader bader added the cuda CUDA back-end label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants