-
Notifications
You must be signed in to change notification settings - Fork 798
Revert "[SYCL] Add implementation of sycl::intel::barrier" #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 3df81ac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder why this regression happened in the first place? As I can see, all LIT tests passed in #2198
Can we just disable failing LIT test instead of reverting the whole patch? |
This is good question. It may be caused by interference of different commits. I was not able to get root cause fast enough so I suggest to revert commit to fix constantly failing test in CI. |
@vladimirlaz, are you going to merge this PR? We need to unblock CI ASAP. |
Which test is failing because of this? |
New test for |
you can find link: http://ci.llvm.intel.com:8010/#/builders/18/builds/3851 |
Ok, thanks. I can't reproduce this failure locally, but I'll see if I can work out what's going on. |
John, please, make sure that your low-level API drivers are up-to-date. There were updated recently. |
I updated the CPU RT to match the file in dependency.conf, but now nothing works because it doesn't ship with a TBB library. See #2220. |
Add new device descriptor to query 2D block array capabilities of the Intel GPU
Reverts #2198
SYCL::barrier.cpp is failing for every run after merging the PR both on Windows and Linux (e.g. http://ci.llvm.intel.com:8010/#/builders/18/builds/3851)