Skip to content

Conversation

vladimirlaz
Copy link
Contributor

Reverts #2198

SYCL::barrier.cpp is failing for every run after merging the PR both on Windows and Linux (e.g. http://ci.llvm.intel.com:8010/#/builders/18/builds/3851)

AlexeySachkov
AlexeySachkov previously approved these changes Aug 5, 2020
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder why this regression happened in the first place? As I can see, all LIT tests passed in #2198

@AlexeySachkov AlexeySachkov dismissed their stale review August 5, 2020 08:09

I've changed my mind

@AlexeySachkov
Copy link
Contributor

Can we just disable failing LIT test instead of reverting the whole patch?

@vladimirlaz
Copy link
Contributor Author

This is good question. It may be caused by interference of different commits. I was not able to get root cause fast enough so I suggest to revert commit to fix constantly failing test in CI.

@bader
Copy link
Contributor

bader commented Aug 5, 2020

@vladimirlaz, are you going to merge this PR? We need to unblock CI ASAP.

@Pennycook
Copy link
Contributor

Which test is failing because of this?

@AlexeySachkov
Copy link
Contributor

Which test is failing because of this?

New test for barrier is failing

@vladimirlaz
Copy link
Contributor Author

Which test is failing because of this?

you can find link: http://ci.llvm.intel.com:8010/#/builders/18/builds/3851

@Pennycook
Copy link
Contributor

Ok, thanks. I can't reproduce this failure locally, but I'll see if I can work out what's going on.

@bader
Copy link
Contributor

bader commented Aug 5, 2020

Ok, thanks. I can't reproduce this failure locally, but I'll see if I can work out what's going on.

John, please, make sure that your low-level API drivers are up-to-date. There were updated recently.
https://github.com/intel/llvm/blob/sycl/buildbot/dependency.conf

@Pennycook
Copy link
Contributor

John, please, make sure that your low-level API drivers are up-to-date. There were updated recently.
https://github.com/intel/llvm/blob/sycl/buildbot/dependency.conf

I updated the CPU RT to match the file in dependency.conf, but now nothing works because it doesn't ship with a TBB library. See #2220.

@bader bader merged commit 4d5b34d into sycl Aug 5, 2020
@bader bader deleted the revert-2198-group-barrier branch August 5, 2020 15:30
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Add new device descriptor to query 2D block array capabilities of the Intel GPU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants