schema: Define a relaxed schema as v1 and move current schema to v2 #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd98dce to
dd605fc
Compare
dd605fc to
ee02b95
Compare
jjasghar
approved these changes
Apr 29, 2024
jjasghar
reviewed
Apr 29, 2024
|
Before merging this PR, we should probably wait until the cli containing instructlab/instructlab#1009 is published. If we merge before then, then we will require |
This happened this afternoon. So we can merge this PR when the backend is ready. |
@shivchander Please let us know when we can merge this and start accepting |
ee02b95 to
dfc537e
Compare
8 tasks
We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. The check_yaml script is updated to allow a schema version to be specified. When the schema-version option is not specified, the script will use the latest schema version from the schema base. If the schema-version is specified as a non-positive integer, then the script will use the version key from the YAML document for the schema version to use. The script is also changed to only check for attribution.txt when the schema version is higher than 1. See instructlab/instructlab#989 Depends on instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
dfc537e to
1045fd0
Compare
jjasghar
pushed a commit
to luke-inglis/taxonomy
that referenced
this pull request
Jun 7, 2024
…nstructlab#769) We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. The check_yaml script is updated to allow a schema version to be specified. When the schema-version option is not specified, the script will use the latest schema version from the schema base. If the schema-version is specified as a non-positive integer, then the script will use the version key from the YAML document for the schema version to use. The script is also changed to only check for attribution.txt when the schema version is higher than 1. See instructlab/instructlab#989 Depends on instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
jjasghar
pushed a commit
to acidonper/taxonomy
that referenced
this pull request
Jun 10, 2024
…nstructlab#769) We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. The check_yaml script is updated to allow a schema version to be specified. When the schema-version option is not specified, the script will use the latest schema version from the schema base. If the schema-version is specified as a non-positive integer, then the script will use the version key from the YAML document for the schema version to use. The script is also changed to only check for attribution.txt when the schema version is higher than 1. See instructlab/instructlab#989 Depends on instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo.
The check_yaml script is updated to allow a schema version to be specified. When the schema-version option is not specified, the script will use the latest schema version from the schema base. If the schema-version is specified as a non-positive integer, then the script will use the version key from the YAML document for the schema version to use.
The script is also changed to only check for attribution.txt when the schema version is higher than 1.
See instructlab/instructlab#989
Depends on instructlab/schema#11